Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932639AbbDMMla (ORCPT ); Mon, 13 Apr 2015 08:41:30 -0400 Received: from foss.arm.com ([217.140.101.70]:59705 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932262AbbDMMl1 (ORCPT ); Mon, 13 Apr 2015 08:41:27 -0400 Date: Mon, 13 Apr 2015 13:41:22 +0100 From: Will Deacon To: Mark Rutland Cc: "msalter@redhat.com" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Punit Agrawal , Suzuki Poulose , "arm@kernel.org" Subject: Re: [PATCH V2] drivers: CCI: fix used_mask init in validate_group() Message-ID: <20150413124121.GF2869@arm.com> References: <20150409144029.GE9648@leverpostej> <1428591425-17330-1-git-send-email-msalter@redhat.com> <20150409153629.GI9648@leverpostej> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150409153629.GI9648@leverpostej> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1173 Lines: 27 On Thu, Apr 09, 2015 at 04:36:29PM +0100, Mark Rutland wrote: > On Thu, Apr 09, 2015 at 03:57:05PM +0100, Mark Salter wrote: > > Currently in validate_group(), there is a static initializer > > for fake_pmu.used_mask which is based on CPU_BITS_NONE but > > the used_mask array size is based on CCI_PMU_MAX_HW_EVENTS. > > CCI_PMU_MAX_HW_EVENTS is not based on NR_CPUS, so CPU_BITS_NONE > > is not correct and will cause a build failure if NR_CPUS > > is set high enough to make CPU_BITS_NONE larger than used_mask. > > > > Signed-off-by: Mark Salter > > Reviewed-by: Mark Rutland > > Arnd, Olof, are you happy to take this via arm-soc? > > My (broken) patch went via Will's tree because of a perf dependency, but > other CCI patches have gone via you guys. Yeah, arm-soc is the best place for this. You should resend to arm@kernel.org as a new patch with the relevant acks. Will -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/