Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932745AbbDMMoQ (ORCPT ); Mon, 13 Apr 2015 08:44:16 -0400 Received: from mail-wi0-f170.google.com ([209.85.212.170]:33298 "EHLO mail-wi0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932729AbbDMMoJ (ORCPT ); Mon, 13 Apr 2015 08:44:09 -0400 Message-ID: <552BBA15.4040500@plexistor.com> Date: Mon, 13 Apr 2015 15:44:05 +0300 From: Boaz Harrosh User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Jan Kara CC: Zhao Lei , "'Christoph Hellwig'" , linux-fsdevel@vger.kernel.org, "'Jens Axboe'" , "'LKML'" Subject: Re: Regression caused by using node_to_bdi() References: <016d01d07380$fc37fc40$f4a7f4c0$@cn.fujitsu.com> <552A57F8.7020002@plexistor.com> <20150413122110.GE3633@quack.suse.cz> In-Reply-To: <20150413122110.GE3633@quack.suse.cz> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1136 Lines: 44 On 04/13/2015 03:21 PM, Jan Kara wrote: <> >> -struct backing_dev_info *inode_to_bdi(struct inode *inode); >> +struct backing_dev_info *__inode_to_bdi(struct inode *inode); >> + >> +static inline >> +struct backing_dev_info *inode_to_bdi(struct inode *inode) >> +{ >> + if (!inode || !inode->i_sb) >> + return __inode_to_bdi(inode); >> + >> + return inode->i_sb->s_bdi; >> +} > This is wrong for block-device inodes, isn't it? Rrr yes my bad I meant +struct backing_dev_info *inode_to_bdi(struct inode *inode) +{ + if (!inode || !inode->i_sb || !inode->i_sb->s_bdi) + return __inode_to_bdi(inode); + + return inode->i_sb->s_bdi; +} I was hopping that blockdev_superblock->s_bdi == NULL because what sb_is_blkdev_sb() is doing is checking for blockdev_superblock. >From code audit I do not see where it might be set but I might have missed it. Thanks Jan Boaz > > Honza > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/