Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932517AbbDMOQy (ORCPT ); Mon, 13 Apr 2015 10:16:54 -0400 Received: from casper.infradead.org ([85.118.1.10]:50139 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754085AbbDMOQw (ORCPT ); Mon, 13 Apr 2015 10:16:52 -0400 Message-Id: <20150413141126.756350256@infradead.org> User-Agent: quilt/0.61-1 Date: Mon, 13 Apr 2015 16:11:26 +0200 From: Peter Zijlstra To: mingo@kernel.org, rusty@rustcorp.com.au, mathieu.desnoyers@efficios.com, oleg@redhat.com, paulmck@linux.vnet.ibm.com, torvalds@linux-foundation.org Cc: linux-kernel@vger.kernel.org, andi@firstfloor.org, rostedt@goodmis.org, tglx@linutronix.de, laijs@cn.fujitsu.com, linux@horizon.com, peterz@infradead.org Subject: [PATCH v5 00/10] latched RB-trees and __module_address() Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1821 Lines: 49 This series is aimed at making __module_address() go fast(er). The reason for doing so is that most stack unwinders use kernel_text_address() to validate each frame. Perf and ftrace (can) end up doing a lot of stack traces from performance sensitive code. On the way there it: - annotates and sanitizes module locking - introduces the latched RB-tree - employs it to make __module_address() go fast. I've build and boot tested this on x86_64 with modules and lockdep enabled. Performance numbers (below) are done with lockdep disabled. As previously mentioned; the reason for writing the latched RB-tree as generic code is mostly for clarity/documentation purposes; as there are a number of separate and non trivial bits to the complete solution. As measued on my ivb-ep system with 84 modules loaded; prior to patching the test module (below) reports (cache hot, performance cpufreq): avg +- stdev Before: 611 +- 10 [ns] per __module_address() call After: 17 +- 5 [ns] per __module_address() call PMI measurements for a cpu running loops in a module (also [ns]): Before: Mean: 2719 +- 1, Stdev: 214, Samples: 40036 After: Mean: 947 +- 0, Stdev: 132, Samples: 40037 Note; I have also tested things like: perf record -a -g modprobe mod_test, to make 'sure' to hit some of the more interesting paths. Changes since last time: - reworked generic latch_tree API (Lai Jiangshan) - reworked module bounds (me) - reworked all the testing code (not included) Rusty, please consider merging this (for 4.2, I know its the merge window, no rush) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/