Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932855AbbDMPnE (ORCPT ); Mon, 13 Apr 2015 11:43:04 -0400 Received: from mail9.hitachi.co.jp ([133.145.228.44]:48889 "EHLO mail9.hitachi.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932816AbbDMPm7 (ORCPT ); Mon, 13 Apr 2015 11:42:59 -0400 Message-ID: <552BE3FC.5060307@hitachi.com> Date: Tue, 14 Apr 2015 00:42:52 +0900 From: Masami Hiramatsu Organization: Hitachi, Ltd., Japan User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:13.0) Gecko/20120614 Thunderbird/13.0.1 MIME-Version: 1.0 To: He Kuang CC: acme@kernel.org, a.p.zijlstra@chello.nl, mingo@redhat.com, namhyung@kernel.org, wangnan0@huawei.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] perf probe: Set retprobe flag when probe in address-based alternative mode References: <1428925290-5623-1-git-send-email-hekuang@huawei.com> In-Reply-To: <1428925290-5623-1-git-send-email-hekuang@huawei.com> Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1860 Lines: 65 (2015/04/13 20:41), He Kuang wrote: > Perf probe misses to set retprobe flag back when falling back to > address-based alternative mode. > > Can be reproduced as following: > > $ perf probe -v -k vmlinux --add='sys_write%return' > ... > Added new event: > Writing event: p:probe/sys_write _stext+1584952 > probe:sys_write (on sys_write%return) > > $ cat /sys/kernel/debug/tracing/kprobe_events > p:probe/sys_write _stext+1584952 > > After this patch: > > $ perf probe -v -k vmlinux --add='sys_write%return' > Added new event: > Writing event: r:probe/sys_write SyS_write+0 > probe:sys_write (on sys_write%return) > > $ cat /sys/kernel/debug/tracing/kprobe_events > r:probe/sys_write SyS_write > > Signed-off-by: He Kuang Oops, I missed that! Acked-by: Masami Hiramatsu Thank you! > --- > tools/perf/util/probe-event.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c > index 30545ce..5483d98 100644 > --- a/tools/perf/util/probe-event.c > +++ b/tools/perf/util/probe-event.c > @@ -332,6 +332,7 @@ static int find_alternative_probe_point(struct debuginfo *dinfo, > else { > result->offset += pp->offset; > result->line += pp->line; > + result->retprobe = pp->retprobe; > ret = 0; > } > > -- Masami HIRAMATSU Linux Technology Research Center, System Productivity Research Dept. Center for Technology Innovation - Systems Engineering Hitachi, Ltd., Research & Development Group E-mail: masami.hiramatsu.pt@hitachi.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/