Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754292AbbDMRjJ (ORCPT ); Mon, 13 Apr 2015 13:39:09 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:53183 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753083AbbDMRjF (ORCPT ); Mon, 13 Apr 2015 13:39:05 -0400 Date: Mon, 13 Apr 2015 13:39:03 -0400 (EDT) Message-Id: <20150413.133903.354139524800441054.davem@davemloft.net> To: dan.carpenter@oracle.com Cc: gnomes@lxorguk.ukuu.org.uk, lambert.quentin@gmail.com, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH 1/2] ide: remove deprecated use of pci api From: David Miller In-Reply-To: <20150413172324.GZ10964@mwanda> References: <20150413132530.210f1d3b@lxorguk.ukuu.org.uk> <20150413.130813.2058573928379941715.davem@davemloft.net> <20150413172324.GZ10964@mwanda> X-Mailer: Mew version 6.6 on Emacs 24.4 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 13 Apr 2015 10:39:05 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1427 Lines: 33 From: Dan Carpenter Date: Mon, 13 Apr 2015 20:23:24 +0300 > On Mon, Apr 13, 2015 at 01:08:13PM -0400, David Miller wrote: >> From: One Thousand Gnomes >> Date: Mon, 13 Apr 2015 13:25:30 +0100 >> >> > On Thu, 9 Apr 2015 13:46:27 +0200 >> > Quentin Lambert wrote: >> > >> >> Replace occurences of the pci api by appropriate call to the dma api. >> >> >> > >> > Drivers/ide is obsolete. It probably ought to go at this point but even >> > so it exists solely in case of a problem or compatibility issue with >> > drivers/ata. Cleaning it up without testing all the drivers makes no >> > sense IMHO. Cleaning it up and testing them doesn't make much sense >> > either. >> >> It's a straightforward transformation, that actually evaluates to what >> the definitions of the deprecated pci DMA interfaces are defined to. > > Almost, except that it uses GFP_KERNEL instead of GFP_DMA. But I > reviewed it and I think it's fine. Quentin sent a GFP_ATOMIC patch as > the first version and I asked him to redo it. Maybe I shouldn't have > done that... No, I'm fine with that part too, don't worry. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/