From: "Hefty, Sean" <sean.hefty@intel.com>
To: "Weiny, Ira" <ira.weiny@intel.com>,
        Michael Wang <yun.wang@profitbricks.com>
CC: Roland Dreier <roland@kernel.org>,
        Hal Rosenstock <hal.rosenstock@gmail.com>,
        "linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Tom Tucker <tom@opengridcomputing.com>,
        Steve Wise <swise@opengridcomputing.com>,
        Hoang-Nam Nguyen <hnguyen@de.ibm.com>,
        Christoph Raisch <raisch@de.ibm.com>,
        infinipath <infinipath@intel.com>, Eli Cohen <eli@mellanox.com>,
        "Latif, Faisal" <faisal.latif@intel.com>,
        Jack Morgenstein <jackm@dev.mellanox.co.il>,
        "Or Gerlitz" <ogerlitz@mellanox.com>,
        Haggai Eran <haggaie@mellanox.com>, "Tom Talpey" <tom@talpey.com>,
        Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
        Doug Ledford <dledford@redhat.com>
Subject: RE: [PATCH v3 04/28] IB/Verbs: Reform IB-core cm
Thread-Topic: [PATCH v3 04/28] IB/Verbs: Reform IB-core cm
Thread-Index: AQHQdeS5UbnEZcMackOuoINyGhKJPJ1LtHWA//+RvsA=
Date: Mon, 13 Apr 2015 18:40:35 +0000
Message-ID: <1828884A29C6694DAF28B7E6B8A82373A8FC0A3A@ORSMSX109.amr.corp.intel.com>
References: <552BB470.4090407@profitbricks.com>
 <552BB552.1030905@profitbricks.com>
 <20150413181248.GA2464@phlsvsds.ph.intel.com>
In-Reply-To: <20150413181248.GA2464@phlsvsds.ph.intel.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1059
Lines: 30

> > -	if (rdma_node_get_transport(ib_device->node_type) !=
> RDMA_TRANSPORT_IB)
> > -		return;
> > +	int count = 0;
> 
> I'm ok with this as an intermediate patch but going forward if we are
> going to
> have calls like
> 
> static inline int cap_ib_cm_dev(struct ib_device *device)

I would rather keep everything to checking per port, not per device.  Specifically, because we have code that does this:

> >  		port = kzalloc(sizeof *port, GFP_KERNEL);
> >  		if (!port)
> >  			goto error1;
> > @@ -3809,7 +3810,16 @@ static void cm_add_one(struct ib_device
> *ib_device)
> >  		ret = ib_modify_port(ib_device, i, 0, &port_modify);
> >  		if (ret)
> >  			goto error3;

It will also help keep the checks consistent, so that we don't end up with CM checks being per device, but SA checks being per port.

- Sean
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/