Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754562AbbDMSpO (ORCPT <rfc822;w@1wt.eu>);
	Mon, 13 Apr 2015 14:45:14 -0400
Received: from mga02.intel.com ([134.134.136.20]:61773 "EHLO mga02.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751177AbbDMSpK (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 13 Apr 2015 14:45:10 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.11,571,1422950400"; 
   d="scan'208";a="679469889"
From: "Hefty, Sean" <sean.hefty@intel.com>
To: Michael Wang <yun.wang@profitbricks.com>,
        Roland Dreier <roland@kernel.org>,
        Hal Rosenstock <hal.rosenstock@gmail.com>,
        "linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
CC: Tom Tucker <tom@opengridcomputing.com>,
        Steve Wise <swise@opengridcomputing.com>,
        Hoang-Nam Nguyen <hnguyen@de.ibm.com>,
        Christoph Raisch <raisch@de.ibm.com>,
        infinipath <infinipath@intel.com>, "Eli Cohen" <eli@mellanox.com>,
        "Latif, Faisal" <faisal.latif@intel.com>,
        "Jack Morgenstein" <jackm@dev.mellanox.co.il>,
        Or Gerlitz <ogerlitz@mellanox.com>, Haggai Eran <haggaie@mellanox.com>,
        "Weiny, Ira" <ira.weiny@intel.com>, "Tom Talpey" <tom@talpey.com>,
        Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
        Doug Ledford <dledford@redhat.com>
Subject: RE: [PATCH v3 05/28] IB/Verbs: Reform IB-core sa_query
Thread-Topic: [PATCH v3 05/28] IB/Verbs: Reform IB-core sa_query
Thread-Index: AQHQdeTS+h+RDWFofkyDSlWZ14OsiJ1LR2ZA
Date: Mon, 13 Apr 2015 18:45:08 +0000
Message-ID: <1828884A29C6694DAF28B7E6B8A82373A8FC0A58@ORSMSX109.amr.corp.intel.com>
References: <552BB470.4090407@profitbricks.com>
 <552BB572.4040300@profitbricks.com>
In-Reply-To: <552BB572.4040300@profitbricks.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.22.254.139]
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from base64 to 8bit by nfs id t3DIjI0k005852
Content-Length: 869
Lines: 22

> @@ -1153,9 +1153,7 @@ static void ib_sa_add_one(struct ib_device *device)
>  {
>  	struct ib_sa_device *sa_dev;
>  	int s, e, i;
> -
> -	if (rdma_node_get_transport(device->node_type) != RDMA_TRANSPORT_IB)
> -		return;
> +	int count = 0;
> 
>  	if (device->node_type == RDMA_NODE_IB_SWITCH)
>  		s = e = 0;
> @@ -1175,7 +1173,7 @@ static void ib_sa_add_one(struct ib_device *device)
> 
>  	for (i = 0; i <= e - s; ++i) {
>  		spin_lock_init(&sa_dev->port[i].ah_lock);
> -		if (rdma_port_get_link_layer(device, i + 1) !=
> IB_LINK_LAYER_INFINIBAND)
> +		if (!rdma_tech_ib(device, i + 1))

Note for someone who cares.  This patch didn't introduce this problem, but I think the port number should be "i + s".

????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m????????????I?