Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932506AbbDMTJR (ORCPT ); Mon, 13 Apr 2015 15:09:17 -0400 Received: from ud10.udmedia.de ([194.117.254.50]:45665 "EHLO mail.ud10.udmedia.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753728AbbDMTJQ (ORCPT ); Mon, 13 Apr 2015 15:09:16 -0400 Date: Mon, 13 Apr 2015 21:09:14 +0200 From: Markus Trippelsdorf To: Linus Torvalds Cc: Ingo Molnar , "H. Peter Anvin" , Denys Vlasenko , "Paul E. McKenney" , Jason Low , Peter Zijlstra , Davidlohr Bueso , Tim Chen , Aswin Chandramouleeswaran , LKML , Borislav Petkov , Andy Lutomirski , Brian Gerst , Thomas Gleixner , Peter Zijlstra Subject: Re: [PATCH] x86: Align jump targets to 1 byte boundaries Message-ID: <20150413190914.GA398@x4> References: <20150410111427.GA30477@gmail.com> <20150410112748.GB30477@gmail.com> <20150410120846.GA17101@gmail.com> <5527C700.3030405@redhat.com> <5527CD92.1080901@zytor.com> <20150411144135.GB31416@x4> <20150412101422.GA2862@gmail.com> <20150413162308.GB398@x4> <20150413172624.GC398@x4> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1367 Lines: 33 On 2015.04.13 at 11:31 -0700, Linus Torvalds wrote: > On Mon, Apr 13, 2015 at 10:26 AM, Markus Trippelsdorf > wrote: > > > > I must have made a measurement mistake above, because the actual code > > size savings are roughly 5%: > > Can you check against the -fno-guess-branch-probability output? text data bss dec filename 8746230 970072 802816 10519118 ./vmlinux gcc-5 (lto) 9202488 978512 811008 10992008 ./vmlinux gcc-5 8036915 970296 802816 9810027 ./vmlinux gcc-5 (lto -fno-guess-branch-probability) 8593615 978512 811008 10383135 ./vmlinux gcc-5 (-fno-guess-branch-probability) > Does lto (without pgo) perhaps end up undoing a lot of the random > "branch out and back" noise? As Honza wrote somewhere else in this thread, gcc uses -fguess-branch-probability to get a profile estimate, that is then used throughout the whole optimization chain. So disabling this option really makes no sense and will result in significant performance loss. On the other hand the LTO code size savings should not affect performance negatively at all. -- Markus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/