Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932771AbbDMVsk (ORCPT ); Mon, 13 Apr 2015 17:48:40 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:40379 "EHLO out4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753683AbbDMVsg (ORCPT ); Mon, 13 Apr 2015 17:48:36 -0400 X-Sasl-enc: ZiZ2UWWShaYoFLA2rRd3J7uRLaOnZcK0vrMW6hUa+F7h 1428961715 Date: Tue, 14 Apr 2015 00:48:34 +0300 From: Sergei Zviagintsev To: Lukasz Skalski Cc: gregkh@linuxfoundation.org, daniel@zonque.org, dh.herrmann@gmail.com, tixxdz@opendz.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] kdbus: do not append the same connection to the queue twice Message-ID: <20150413214834.GE8500@localhost.localdomain> References: <1428934446-32364-1-git-send-email-l.skalski@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1428934446-32364-1-git-send-email-l.skalski@samsung.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1873 Lines: 58 Hi Lukasz, On Mon, Apr 13, 2015 at 04:14:06PM +0200, Lukasz Skalski wrote: > As it was discussed on systemd ML [1], the same connection should be > queued up only once for a given well-known name. > > [1] http://lists.freedesktop.org/archives/systemd-devel/2015-April/030494.html > > Signed-off-by: Lukasz Skalski > > diff --git a/ipc/kdbus/names.c b/ipc/kdbus/names.c > index 657008e..a546a84 100644 > --- a/ipc/kdbus/names.c > +++ b/ipc/kdbus/names.c > @@ -353,10 +353,23 @@ int kdbus_name_acquire(struct kdbus_name_registry *reg, > } else if (flags & KDBUS_NAME_QUEUE) { > /* add to waiting-queue of the name */ > > - ret = kdbus_name_pending_new(e, conn, flags); > - if (ret >= 0) > - /* tell the caller that we queued it */ > - rflags |= KDBUS_NAME_IN_QUEUE; > + struct kdbus_name_pending *p; > + bool in_queue = false; > + > + list_for_each_entry(p, &e->queue, name_entry) { > + if (p->conn == conn) { > + /* connection is already queued */ > + rflags |= KDBUS_NAME_IN_QUEUE; > + in_queue = true; break here? > + } > + } > + > + if (!in_queue) { > + ret = kdbus_name_pending_new(e, conn, flags); > + if (ret >= 0) > + /* tell the caller that we queued it */ > + rflags |= KDBUS_NAME_IN_QUEUE; > + } > } else { > /* the name is busy, return a failure */ > ret = -EEXIST; > -- > 1.9.3 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/