Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752943AbbDNGje (ORCPT ); Tue, 14 Apr 2015 02:39:34 -0400 Received: from mail-pd0-f170.google.com ([209.85.192.170]:34819 "EHLO mail-pd0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751381AbbDNGj1 (ORCPT ); Tue, 14 Apr 2015 02:39:27 -0400 MIME-Version: 1.0 In-Reply-To: <1428951432.3868.21.camel@x220> References: <1428941550-4620-1-git-send-email-punnaia@xilinx.com> <858a607d-7c5a-4066-aa79-ab14c456b8e5@BN1BFFO11FD046.protection.gbl> <1428951432.3868.21.camel@x220> Date: Tue, 14 Apr 2015 12:09:26 +0530 X-Google-Sender-Auth: lMOFfJZoXF9V-Qu10C6b7F8be0U Message-ID: Subject: Re: [PATCH v6 1/3] nand: pl353: Add basic driver for arm pl353 smc nand interface From: punnaiah choudary kalluri To: Paul Bolle Cc: Punnaiah Choudary Kalluri , "robh+dt@kernel.org" , "pawel.moll@arm.com" , "mark.rutland@arm.com" , "ijc+devicetree@hellion.org.uk" , Kumar Gala , Rob Landley , "michal.simek@xilinx.com" , Grant Likely , "gregkh@linuxfoundation.org" , "jason@lakedaemon.net" , "ezequiel.garcia@free-electrons.com" , Arnd Bergmann , David Woodhouse , Brian Norris , "artem.bityutskiy@linux.intel.com" , "jussi.kivilinna@iki.fi" , Alexandre Courbot , "Khoronzhuk, Ivan" , "joern@logfs.org" , "devicetree@vger.kernel.org" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-mtd@lists.infradead.org" , Punnaiah Choudary Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1503 Lines: 49 Hi Paul Bolle, On Tue, Apr 14, 2015 at 12:27 AM, Paul Bolle wrote: > On Mon, 2015-04-13 at 21:42 +0530, Punnaiah Choudary Kalluri wrote: > >> --- a/drivers/mtd/nand/Makefile >> +++ b/drivers/mtd/nand/Makefile > >> +obj-$(CONFIG_MTD_NAND_PL353) += pl353_nand.o > > (I think pl353_nand.o can be part of a module. If that's incorrect, you > can stop reading here.) > >> --- /dev/null >> +++ b/drivers/mtd/nand/pl353_nand.c > >> + * This program is free software; you can redistribute it and/or modify it under >> + * the terms of the GNU General Public License version 2 as published by the >> + * Free Software Foundation; either version 2 of the License, or (at your >> + * option) any later version. > > This states the license of this driver is GPL v2 or later. > >> +MODULE_LICENSE("GPL v2"); > > And according to include/linux/module.h this states the license is GPL > v2. So either the comment at the top of this file or the license ident > used in the MODULE_LICENSE() macro needs to change. Thanks for the review. I will change the licence ident to "GPL". I will wait some time for further functional comments on this driver before sending the next version of patches. Regards, Punnaiah > > Thanks, > > > Paul Bolle > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/