Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753232AbbDNIH3 (ORCPT ); Tue, 14 Apr 2015 04:07:29 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:39946 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752447AbbDNIH0 (ORCPT ); Tue, 14 Apr 2015 04:07:26 -0400 Date: Tue, 14 Apr 2015 11:07:03 +0300 From: Dan Carpenter To: Mateusz Kulikowski Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 13/21] staging: rtl8192e: Fix PREFER_PR_LEVEL warnings Message-ID: <20150414080703.GE10964@mwanda> References: <1428961664-4241-1-git-send-email-mateusz.kulikowski@gmail.com> <1428961664-4241-14-git-send-email-mateusz.kulikowski@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1428961664-4241-14-git-send-email-mateusz.kulikowski@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1818 Lines: 46 On Mon, Apr 13, 2015 at 11:47:36PM +0200, Mateusz Kulikowski wrote: > Fix most of remaining PREFER_PR_LEVEL warnings in rtllib. > Replace printk() with pr_* where possible. > > Signed-off-by: Mateusz Kulikowski > --- > drivers/staging/rtl8192e/rtllib.h | 4 +- > drivers/staging/rtl8192e/rtllib_crypt.c | 17 ++++---- > drivers/staging/rtl8192e/rtllib_crypt_tkip.c | 59 +++++++++++----------------- > drivers/staging/rtl8192e/rtllib_rx.c | 4 +- > 4 files changed, 34 insertions(+), 50 deletions(-) > > diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h > index 472e880..fd7b7a5 100644 > --- a/drivers/staging/rtl8192e/rtllib.h > +++ b/drivers/staging/rtl8192e/rtllib.h > @@ -685,13 +685,13 @@ extern u32 rtllib_debug_level; > #define RTLLIB_DEBUG(level, fmt, args...) \ > do { \ > if (rtllib_debug_level & (level)) \ > - printk(KERN_DEBUG "rtllib: " fmt, ## args); \ > + pr_debug("rtllib: " fmt, ## args); \ > } while (0) > > #define RTLLIB_DEBUG_DATA(level, data, datalen) \ > do { \ > if ((rtllib_debug_level & (level)) == (level)) { \ > - printk(KERN_DEBUG "rtllib: %s()\n", __func__); \ > + pr_debug("rtllib: %s()\n", __func__); \ > print_hex_dump_bytes(KERN_DEBUG, DUMP_PREFIX_NONE, \ > data, datalen); \ > } \ We've made it slightly more tricky to turn on these debug statements. I don't think that's a big problem. I don't think anyone cares about them. They are just noise is my guess. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/