Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753910AbbDNJUv (ORCPT ); Tue, 14 Apr 2015 05:20:51 -0400 Received: from mail-qk0-f174.google.com ([209.85.220.174]:32824 "EHLO mail-qk0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753337AbbDNJUl (ORCPT ); Tue, 14 Apr 2015 05:20:41 -0400 MIME-Version: 1.0 In-Reply-To: <1428934061-29217-1-git-send-email-javier.martinez@collabora.co.uk> References: <1428934061-29217-1-git-send-email-javier.martinez@collabora.co.uk> Date: Tue, 14 Apr 2015 11:20:40 +0200 Message-ID: Subject: Re: [PATCH 1/1] mmc: pwrseq: Fix error code propagation in mmc_pwrseq_simple_alloc() From: Ulf Hansson To: Javier Martinez Canillas Cc: Alexandre Courbot , Marek Szyprowski , Olof Johansson , Doug Anderson , Kevin Hilman , linux-mmc , "linux-kernel@vger.kernel.org" , linux-samsung-soc Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1636 Lines: 46 On 13 April 2015 at 16:07, Javier Martinez Canillas wrote: > If the struct mmc_pwrseq_match .alloc function used to allocate a > struct mmc_pwrseq fails, the error is propagated to mmc_of_parse(). > > But instead of returning the error code in pwrseq, host->pwrseq is > returned which will always be 0. So mmc_of_parse() succeeds even if > the pwrseq .alloc function failed and host->pwrseq is NULL. > > This makes the SDIO device to not be powered if the power sequencing > .alloc functions wants to be deferred due a missing resource because > the mmc controller driver probe did wrongly succeed. > > Fixes: 0f12a0ce4ce4a ("mmc: pwrseq: simplify alloc/free hooks") > Signed-off-by: Javier Martinez Canillas Thanks! Applied for fixes. Kind regards Uffe > --- > drivers/mmc/core/pwrseq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/core/pwrseq.c b/drivers/mmc/core/pwrseq.c > index ab2129781161..4c1d1757dbf9 100644 > --- a/drivers/mmc/core/pwrseq.c > +++ b/drivers/mmc/core/pwrseq.c > @@ -73,7 +73,7 @@ int mmc_pwrseq_alloc(struct mmc_host *host) > > pwrseq = match->alloc(host, &pdev->dev); > if (IS_ERR(pwrseq)) { > - ret = PTR_ERR(host->pwrseq); > + ret = PTR_ERR(pwrseq); > goto err; > } > > -- > 2.1.4 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/