Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932077AbbDNKNm (ORCPT ); Tue, 14 Apr 2015 06:13:42 -0400 Received: from e06smtp15.uk.ibm.com ([195.75.94.111]:39985 "EHLO e06smtp15.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754415AbbDNKNe (ORCPT ); Tue, 14 Apr 2015 06:13:34 -0400 Date: Tue, 14 Apr 2015 12:13:27 +0200 From: Cornelia Huck To: "Michael S. Tsirkin" Cc: linux-kernel@vger.kernel.org, Rusty Russell , virtualization@lists.linux-foundation.org, linux-api@vger.kernel.org Subject: Re: [PATCH] virtio_balloon: drop virtio_balloon_stat_modern Message-ID: <20150414121327.4caacfba.cornelia.huck@de.ibm.com> In-Reply-To: <1429005625-23181-1-git-send-email-mst@redhat.com> References: <1429005625-23181-1-git-send-email-mst@redhat.com> Organization: IBM Deutschland Research & Development GmbH Vorsitzende des Aufsichtsrats: Martina Koederitz =?UTF-8?B?R2VzY2jDpGZ0c2bDvGhydW5nOg==?= Dirk Wittkopp Sitz der Gesellschaft: =?UTF-8?B?QsO2Ymxpbmdlbg==?= Registergericht: Amtsgericht Stuttgart, HRB 243294 X-Mailer: Claws Mail 3.8.0 (GTK+ 2.24.10; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15041410-0021-0000-0000-00000391694C Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1157 Lines: 31 On Tue, 14 Apr 2015 12:01:13 +0200 "Michael S. Tsirkin" wrote: > Looks like we are better off sticking with the misaligned stat struct, > to reduce the amount of virtio 1 specific code in balloon. So let's do > it. > > Add a detailed comment to reduce the chance people copy this bad example. > > This also fixes a bug on BE architectures: tag should use > cpu_to_le16, not cpu_to_le32. > > Acked-by: Cornelia Huck > Signed-off-by: Michael S. Tsirkin > --- > > Just reposting so it's easier to apply. > Feel free to squash into previous patch if you think it's > neater. +1 for squashing from me. My A-b would also apply to the squashed patch. > > include/uapi/linux/virtio_balloon.h | 33 +++++++++++++++++++++++++-------- > drivers/virtio/virtio_balloon.c | 19 ++++--------------- > 2 files changed, 29 insertions(+), 23 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/