Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755401AbbDNMSb (ORCPT <rfc822;w@1wt.eu>);
	Tue, 14 Apr 2015 08:18:31 -0400
Received: from mail-qk0-f174.google.com ([209.85.220.174]:33092 "EHLO
	mail-qk0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1755362AbbDNMSD (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 14 Apr 2015 08:18:03 -0400
Date: Tue, 14 Apr 2015 08:17:32 -0400
From: Tejun Heo <tj@kernel.org>
To: Aleksa Sarai <cyphar@cyphar.com>
Cc: lizefan@huawei.com, mingo@redhat.com, peterz@infradead.org, richard@nod.at,
        =?iso-8859-1?Q?Fr=E9d=E9ric?= Weisbecker <fweisbec@gmail.com>,
        linux-kernel@vger.kernel.org, cgroups@vger.kernel.org
Subject: Re: [PATCH v9 3/4] cgroups: allow a cgroup subsystem to reject a fork
Message-ID: <20150414121732.GL2596@htj.duckdns.org>
References: <1428799917-15141-1-git-send-email-cyphar@cyphar.com>
 <1428799917-15141-4-git-send-email-cyphar@cyphar.com>
 <20150413142439.GA2596@htj.duckdns.org>
 <CAOviyajqc_ip2Lpa5NTLLXxQ7JghYXg1UL3vXDdpbbnhmsfXEQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAOviyajqc_ip2Lpa5NTLLXxQ7JghYXg1UL3vXDdpbbnhmsfXEQ@mail.gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 973
Lines: 31

Hello,

On Tue, Apr 14, 2015 at 10:33:41AM +1000, Aleksa Sarai wrote:
> Hi Tejun,
> 
> > Ummm... is this really necessary?  Can't we do something like the
> > following?
> >
> > #define SUBSYS_TAG(tag)                                         \
> >         __##tag,                                                \
> >         tag = __##tag - 2,
> 
> Is which part necessary? That's what TAG() does. I can remove the

The complex macros.

> UNUSED_IDENT() if you want, that was just to make sure you don't get clashes
> with other unused idents. COUNT() is so that we don't have to manually add
> CGROUP_<TAG>_COUNT for every tag we add.

Let's please do the simple thing.  It just takes one two-liner macro.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/