Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753530AbbDNMdY (ORCPT ); Tue, 14 Apr 2015 08:33:24 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:50016 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752877AbbDNMdQ (ORCPT ); Tue, 14 Apr 2015 08:33:16 -0400 Date: Tue, 14 Apr 2015 14:35:17 +0200 From: Quentin Casasnovas To: Thierry Reding Cc: Quentin Casasnovas , lkml , Oleg Nesterov , Borislav Petkov , Linus Torvalds , Rusty Russell Subject: Re: [PATCH 7/7] modpost: handle relocations mismatch in __ex_table. Message-ID: <20150414123516.GB2925@chrystal.uk.oracle.com> References: <1426596002-26128-1-git-send-email-quentin.casasnovas@oracle.com> <1426596002-26128-8-git-send-email-quentin.casasnovas@oracle.com> <20150414121405.GA30442@ulmo.nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150414121405.GA30442@ulmo.nvidia.com> User-Agent: Mutt/1.5.22 (2013-10-16) X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1607 Lines: 34 On Tue, Apr 14, 2015 at 02:14:14PM +0200, Thierry Reding wrote: > On Tue, Mar 17, 2015 at 01:40:02PM +0100, Quentin Casasnovas wrote: > > If one of these addresses point to a non-executable section, something is > > seriously wrong since it either means the kernel will never fault from > > there or it will not be able to jump to there. As both cases are serious > > enough, we simply error out in these cases so the build fails and the > > developper has to fix the issue. > > > > Signed-off-by: Quentin Casasnovas > > --- > > scripts/mod/modpost.c | 141 ++++++++++++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 141 insertions(+) > > This causes a bunch of mismatch warnings on 32-bit and 64-bit ARM > because there are two additional sections, .text.fixup and > .exception.text that store executable code. I've attached a patch > to fix those, but feel free to squash that into the original commit > if that's still possible. > Thanks Thierry! Your patch looks good to me, though I was wondering if we should just add .text.* in the TEXT_SECTIONS macro. Some architectures define -ffunction-sections (parisc, score, metag and frv) so there are tons of useless warnings on these.. It also means the current modpost sanity checks don't run for those so it might even uncover some real mismatch ;) Quentin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/