Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755269AbbDNNZk (ORCPT ); Tue, 14 Apr 2015 09:25:40 -0400 Received: from mout.kundenserver.de ([212.227.17.10]:56813 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753196AbbDNNZd (ORCPT ); Tue, 14 Apr 2015 09:25:33 -0400 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: Bintian , mark.rutland@arm.com, dan.zhao@hisilicon.com, btw@mail.itp.ac.cn, catalin.marinas@arm.com, wangbinghui@hisilicon.com, will.deacon@arm.com, huxinwei@huawei.com, haojian.zhuang@linaro.org, yanhaifeng@gmail.com, rob.herring@linaro.org, mturquette@linaro.org, xuwei5@hisilicon.com, jh80.chung@samsung.com, sledge.yanwei@huawei.com, kong.kongxinwei@hisilicon.com, heyunlei@huawei.com, w.f@huawei.com, zhangfei.gao@linaro.org, z.liuxinliang@huawei.com, devicetree@vger.kernel.org, khilman@linaro.org, pawel.moll@arm.com, ijc+devicetree@hellion.org.uk, puck.chen@hisilicon.com, xuejiancheng@huawei.com, robh+dt@kernel.org, linux@arm.linux.org.uk, tyler.baker@linaro.org, zhenwei.wang@hisilicon.com, guodong.xu@linaro.org, victor.lixin@hisilicon.com, sboyd@codeaurora.org, linux-kernel@vger.kernel.org, tomeu.vizoso@collabora.com, galak@codeaurora.org, olof@lixom.net, jorge.ramirez-ortiz@linaro.org, xuyiping@hisilicon.com, liguozhu@hisilicon.com Subject: Re: [PATCH v2 3/6] clk: hi6220: Document devicetree bindings for hi6220 clock Date: Tue, 14 Apr 2015 15:20:28 +0200 Message-ID: <5065055.RUNnjWsHWj@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <552D09F7.7080603@huawei.com> References: <1428916660-25910-1-git-send-email-bintian.wang@huawei.com> <2456827.cDpE8M58pn@wuerfel> <552D09F7.7080603@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:Uyud5gD4WgvUZr6dt5HXFAc0NNGdvZElui/0IQ5opCir8alo5yx yUH5d93Ex4bdM8doj7OhcKt0xlqGwa6CgQPgIJUdUvc4KL0POA8xG86vJT36mplcdWu2JPT PD1kEx20CnP8M9BKjRjUA+Yabv6tU5quoOX5e7ZL1emTq48SaBnAFfOp2BbkP3yRWJdZ1hh EbPYLVXw1s8B6gxGoKGMQ== X-UI-Out-Filterresults: notjunk:1; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 919 Lines: 28 On Tuesday 14 April 2015 20:37:11 Bintian wrote: > It's really a smart fix! > > For the four system controllers, how about change the following strings: > + - "hisilicon,aoctrl" > + - "hisilicon,sysctrl" > + - "hisilicon,mediactrl" > + - "hisilicon,pmctrl" > > to > + - "hisilicon,hi6220-aoctrl" > + - "hisilicon,hi6220-sysctrl" > + - "hisilicon,hi6220-mediactrl" > + - "hisilicon,hi6220-pmctrl" Yes, that works. > and I also use "hisilicon,hi6220-xxxx" for hi6220 clk driver directly ? Seems fine to me, though I'd have to look at the bigger picture to see any potential problems. At the moment, I don't see any. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/