Message-ID: <552D22C9.6090503@ti.com>
Date: Tue, 14 Apr 2015 19:53:05 +0530
From: Kishon Vijay Abraham I <kishon@ti.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0
MIME-Version: 1.0
To: Arnd Bergmann <arnd@arndb.de>, <linux-arm-kernel@lists.infradead.org>
CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        <bcm-kernel-feedback-list@broadcom.com>,
        Thomas Pugliese <thomas.pugliese@gmail.com>,
        Peter Griffin <peter.griffin@linaro.org>,
        Jonathan Richardson <jonathar@broadcom.com>,
        Anatol Pomazau <anatol@google.com>, Ray Jui <rjui@broadcom.com>,
        Alan Stern <stern@rowland.harvard.edu>,
        Arun Ramamurthy <arun.ramamurthy@broadcom.com>,
        Dmitry Torokhov <dtor@google.com>, David Mosberger <davidm@egauge.net>,
        Gregory CLEMENT <gregory.clement@free-electrons.com>,
        Kevin Hao <haokexin@gmail.com>, Paul Bolle <pebolle@tiscali.nl>,
        Mathias Nyman <mathias.nyman@linux.intel.com>,
        Scott Branden <sbranden@broadcom.com>, <linux-usb@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, Felipe Balbi <balbi@ti.com>,
        Tony Prisk <linux@prisktech.co.nz>
Subject: Re: [PATCHv2 2/3] usb: ehci-platform: Use devm_of_phy_get_by_index
References: <1428963047-23666-1-git-send-email-arun.ramamurthy@broadcom.com> <6483716.157BQAaRqF@wuerfel> <20150414123737.GB18756@kroah.com> <2433709.D3gBAte9Iu@wuerfel>
In-Reply-To: <2433709.D3gBAte9Iu@wuerfel>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1451
Lines: 36

Hi Arnd,

On Tuesday 14 April 2015 06:47 PM, Arnd Bergmann wrote:
> On Tuesday 14 April 2015 14:37:37 Greg Kroah-Hartman wrote:
>> On Tue, Apr 14, 2015 at 01:33:08PM +0200, Arnd Bergmann wrote:
>>> This is true, but all other drivers do the same for GENERIC_PHY at the
>>> moment. If this one gets changed, we should probably apply the same
>>> solution to all current users and fix them consistently.
>>>
>>> We can do one of these two:
>>>
>>> a) make sure that the framework has 'static inline' stubs that let you
>>>     build all drivers using it when the framework itself is disabled.
>>
>> Yes, please do that.
>>
>>> b) change the drivers using it to 'depends on', and make GENERIC_PHY
>>>     itself a hidden option without a Kconfig prompt.
>>
>> Then how could GENERIC_PHY ever get set?
>
> Right now, every driver that provides a phy uses 'select GENERIC_PHY',
> and they would have to keep doing that. This is not unlike what we
> do for other silent symbols like MFD_CORE, REGMAP_I2C, or PINCTRL,
> and it's not as problematic as 'select' on a user-visible option,
> or (worst) mixing 'select' and 'depends on'.

Sorry, didn't get how GENERIC_PHY could be set with option 'b'.

Thanks
Kishon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/