Date: Tue, 14 Apr 2015 16:44:02 +0200
From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: I_CLEAR bug while shrinking dcache
Message-ID: <20150414144402.GN3107@type.bordeaux.inria.fr>
Mail-Followup-To: Samuel Thibault <samuel.thibault@ens-lyon.org>,
	Al Viro <viro@ZenIV.linux.org.uk>, linux-fsdevel@vger.kernel.org,
	linux-kernel@vger.kernel.org
References: <20150414081254.GD14691@type.youpi.perso.aquilenet.fr>
 <20150414124428.GW889@ZenIV.linux.org.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20150414124428.GW889@ZenIV.linux.org.uk>
User-Agent: Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 888
Lines: 24

Al Viro, le Tue 14 Apr 2015 13:44:29 +0100, a ?crit :
> On Tue, Apr 14, 2015 at 10:12:54AM +0200, Samuel Thibault wrote:
> > So it seems that shrink_dentry_list was trying to kill an inode which
> > already has I_CLEAR.  I'll be trying the attached patch in the next
> > days.
> 
> That patch is just papering over the problem.

I never said it was a proper fix :)

> The first variant can happen, but in that case it should have had
> DCACHE_DENTRY_KILLED set by said __dentry_kill() and skipped.  The other
> two are clear inode refcounting bugs.
> 
> Do you have a reproducer for that?

It just happened in the middle of the night.

Samuel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/