Message-ID: <1429025126.7346.36.camel@edumazet-glaptop2.roam.corp.google.com>
Subject: Re: [PATCH] netns: deinline net_generic()
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Denys Vlasenko <dvlasenk@redhat.com>
Cc: "David S. Miller" <davem@davemloft.net>,
        "Eric W. Biederman" <ebiederm@xmission.com>,
        Jan Engelhardt <jengelh@medozas.de>, Jiri Pirko <jpirko@redhat.com>,
        linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Date: Tue, 14 Apr 2015 08:25:26 -0700
In-Reply-To: <552D2C89.6080601@redhat.com>
References: <1429014311-19868-1-git-send-email-dvlasenk@redhat.com>
	 <1429017572.7346.20.camel@edumazet-glaptop2.roam.corp.google.com>
	 <552D1CD7.7040705@redhat.com>
	 <1429021301.7346.29.camel@edumazet-glaptop2.roam.corp.google.com>
	 <552D2C89.6080601@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 925
Lines: 29

On Tue, 2015-04-14 at 17:04 +0200, Denys Vlasenko wrote:
> On 04/14/2015 04:21 PM, Eric Dumazet wrote:
> > On Tue, 2015-04-14 at 15:57 +0200, Denys Vlasenko wrote:
> > 
> >> My allyesconfig, with BUG_ON's commented out:
> >>
> > 
> > Right. But I can tell you nobody uses lockdep on a production kernel.
> > 
> > Here, at Google, we get what I described.
> 
> I'm trying to get to the .config which generates a small function.
> 
> So far, with LOCKDEP off, it is still this big:
> 

If you read exactly what I wrote, you'll understand that at Google,
rcu_read_lock() & rcu_read_unlock() are nop.

Your patch is based on a worst case scenario, and will slow down our use
case.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/