Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756015AbbDNPxU (ORCPT ); Tue, 14 Apr 2015 11:53:20 -0400 Received: from mail-la0-f46.google.com ([209.85.215.46]:33372 "EHLO mail-la0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755733AbbDNPxK (ORCPT ); Tue, 14 Apr 2015 11:53:10 -0400 MIME-Version: 1.0 In-Reply-To: <20150414140914.GE5989@kroah.com> References: <1429004697-28320-1-git-send-email-hock.leong.kweh@intel.com> <1429004697-28320-3-git-send-email-hock.leong.kweh@intel.com> <20150414140914.GE5989@kroah.com> From: Andy Lutomirski Date: Tue, 14 Apr 2015 11:52:48 -0400 Message-ID: Subject: Re: [PATCH v4 2/2] efi: an sysfs interface for user to update efi firmware To: Greg Kroah-Hartman Cc: "Kweh, Hock Leong" , Ming Lei , Matt Fleming , Ong Boon Leong , LKML , "linux-efi@vger.kernel.org" , Sam Protsenko , Peter Jones , Roy Franz , Borislav Petkov Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1075 Lines: 25 On Tue, Apr 14, 2015 at 10:09 AM, Greg Kroah-Hartman wrote: > On Tue, Apr 14, 2015 at 05:44:56PM +0800, Kweh, Hock Leong wrote: >> From: "Kweh, Hock Leong" >> >> Introducing a kernel module to expose capsule loader interface >> for user to upload capsule binaries. This module leverage the >> request_firmware_direct_full_path() to obtain the binary at a >> specific path input by user. >> >> Example method to load the capsule binary: >> echo -n "/path/to/capsule/binary" > /sys/devices/platform/efi_capsule_loader/capsule_loader > > Ick, why not just have the firmware file location present, and copy it > to the sysfs file directly from userspace, instead of this two-step > process? Because it's not at all obvious how error handling should work in that case. --Andy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/