Message-ID: <1429028051.7346.40.camel@edumazet-glaptop2.roam.corp.google.com>
Subject: Re: [PATCH linux-next 1/4] infiniband/ipoib: fix possible NULL
 pointer dereference in ipoib_get_iflink
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Honggang LI <honli@redhat.com>
Cc: Nicolas Dichtel <nicolas.dichtel@6wind.com>, roland@kernel.org,
        sean.hefty@intel.com, hal.rosenstock@gmail.com, kaber@trash.net,
        davem@davemloft.net, alex.estrin@intel.com, dledford@redhat.com,
        edumazet@google.com, erezsh@mellanox.com, maheshb@google.com,
        jbenc@redhat.com, ebiederm@xmission.com, elfring@users.sourceforge.net,
        f.fainelli@gmail.com, linux@roeck-us.net, andrew@lunn.ch,
        sfeldma@gmail.com, alexander.h.duyck@intel.com,
        linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
        netdev@vger.kernel.org
Date: Tue, 14 Apr 2015 09:14:11 -0700
In-Reply-To: <20150414155307.GD21856@honli.nay.redhat.com>
References: <1429024817-21561-1-git-send-email-honli@redhat.com>
	 <1429024817-21561-2-git-send-email-honli@redhat.com>
	 <1429025673.7346.37.camel@edumazet-glaptop2.roam.corp.google.com>
	 <20150414154422.GB21856@honli.nay.redhat.com> <552D3723.9050706@6wind.com>
	 <20150414155307.GD21856@honli.nay.redhat.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1687
Lines: 51

On Tue, 2015-04-14 at 23:53 +0800, Honggang LI wrote:
> On Tue, Apr 14, 2015 at 05:49:55PM +0200, Nicolas Dichtel wrote:
> > Le 14/04/2015 17:44, Honggang LI a écrit :
> > >On Tue, Apr 14, 2015 at 08:34:33AM -0700, Eric Dumazet wrote:
> > >>On Tue, 2015-04-14 at 23:20 +0800, Honggang Li wrote:
> > >>>Starting monitoring for VG vg_rdma01:   3 logical volume(s) in volume
> > >>>group "vg_rdma01" monitored
> > >>>[  OK  ]
> > >>
> > >>
> > >>>CR2: 0000000000000120
> > >>>---[ end trace a8610f6e9640eb85 ]---
> > >>>
> > >>>Signed-off-by: Honggang Li <honli@redhat.com>
> > >>
> > >>When was this bug added ?
> > >>
> > >
> > >Sorry, I do not know. I ran into this bug today when I'm tracing a race
> > >condition issue related qib. In order to check upstream linux-next fix
> > >the race condition or not, I build linux-next-20150414 on two machines. Both
> > >machines panic at modprobe ib_ipoib. Do you means I need to report a
> > >bug? But I do not know report to who or where.
> > 
> > Here is the tag:
> > Fixes: 5aa7add8f14b ("infiniband/ipoib: implement ndo_get_iflink")
> >
> 
> thank you. 

By adding a proper tag you :

1) Assert you did a research in git history/blame to find original
commit.

2) You looked at other similar bugs added by this commit

3) Add meta information in git history to ease backports

4) CC original author to let him/her know he made a mistake and increase
his/her knowledge.

5) Help maintainers


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/