Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755941AbbDNRr0 (ORCPT ); Tue, 14 Apr 2015 13:47:26 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:36206 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755565AbbDNRrT (ORCPT ); Tue, 14 Apr 2015 13:47:19 -0400 Date: Tue, 14 Apr 2015 13:47:10 -0400 (EDT) Message-Id: <20150414.134710.294383659780001841.davem@davemloft.net> To: honli@redhat.com Cc: kaber@trash.net, roland@kernel.org, sean.hefty@intel.com, hal.rosenstock@gmail.com, alex.estrin@intel.com, dledford@redhat.com, edumazet@google.com, erezsh@mellanox.com, nicolas.dichtel@6wind.com, maheshb@google.com, jbenc@redhat.com, ebiederm@xmission.com, elfring@users.sourceforge.net, f.fainelli@gmail.com, linux@roeck-us.net, andrew@lunn.ch, sfeldma@gmail.com, alexander.h.duyck@intel.com, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH linux-next 3/4] macvlan: fix possible NULL pointer dereference in macvlan_dev_get_iflink From: David Miller In-Reply-To: <20150414153239.GA21856@honli.nay.redhat.com> References: <1429024817-21561-4-git-send-email-honli@redhat.com> <20150414152626.GJ7874@acer.localdomain> <20150414153239.GA21856@honli.nay.redhat.com> X-Mailer: Mew version 6.6 on Emacs 24.4 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 14 Apr 2015 10:47:18 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 766 Lines: 20 From: Honggang LI Date: Tue, 14 Apr 2015 23:32:39 +0800 > On Tue, Apr 14, 2015 at 04:26:27PM +0100, Patrick McHardy wrote: >> >> That is completely useless. vlan (=netdev_priv) can not be NULL as >> netdev_priv() never returns NULL and vlan->lowerdev is always valid >> because a macvlan wouldn't make much sense otherwise. > > OK, please drop this patch. That's not how this works. When a patch series needs any chnages, you must make a fresh, new complete submission of the entire patch series. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/