Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753507AbbDNSA3 (ORCPT ); Tue, 14 Apr 2015 14:00:29 -0400 Received: from www.linutronix.de ([62.245.132.108]:37417 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752480AbbDNSAW (ORCPT ); Tue, 14 Apr 2015 14:00:22 -0400 Date: Tue, 14 Apr 2015 20:00:44 +0200 (CEST) From: Thomas Gleixner To: Adrian-Ken Rueegsegger cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] genirq: Only call irq_ack if implemented by chip In-Reply-To: <1429007347-7167-1-git-send-email-ken@codelabs.ch> Message-ID: References: <1429007347-7167-1-git-send-email-ken@codelabs.ch> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1343 Lines: 42 On Tue, 14 Apr 2015, Adrian-Ken Rueegsegger wrote: > Restore the check if an IRQ chip implements the irq_ack function prior > to its invocation. Commit 22a49163e90d ("genirq: Provide compat handling > for chip->ack()") removed the check from handle_edge_irq while keeping > the check in other call paths. How's an edge triggered interrupt without ack supposed to work? You are missing to describe which problem you solve. Thanks, tglx > Signed-off-by: Adrian-Ken Rueegsegger > --- > kernel/irq/chip.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c > index eb9a4ea..3889b02 100644 > --- a/kernel/irq/chip.c > +++ b/kernel/irq/chip.c > @@ -586,7 +586,8 @@ handle_edge_irq(unsigned int irq, struct irq_desc *desc) > kstat_incr_irqs_this_cpu(irq, desc); > > /* Start handling the irq */ > - desc->irq_data.chip->irq_ack(&desc->irq_data); > + if (desc->irq_data.chip->irq_ack) > + desc->irq_data.chip->irq_ack(&desc->irq_data); > > do { > if (unlikely(!desc->action)) { > -- > 1.7.10.4 > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/