Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754433AbbDNTlI (ORCPT ); Tue, 14 Apr 2015 15:41:08 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:59671 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754343AbbDNTlB convert rfc822-to-8bit (ORCPT ); Tue, 14 Apr 2015 15:41:01 -0400 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2098\)) Subject: Re: [RFC PATCH 4/5] arm64: smp: move the pen to a header file From: Kumar Gala In-Reply-To: <20150414155941.GK28709@leverpostej> Date: Tue, 14 Apr 2015 14:40:57 -0500 Cc: "linux-arm-msm@vger.kernel.org" , Catalin Marinas , Will Deacon , "linux-kernel@vger.kernel.org" , "arm@kernel.org" , Abhimanyu Kapur , "linux-arm-kernel@lists.infradead.org" Content-Transfer-Encoding: 8BIT Message-Id: References: <1428601031-5366-1-git-send-email-galak@codeaurora.org> <1428601031-5366-5-git-send-email-galak@codeaurora.org> <20150414155941.GK28709@leverpostej> To: Mark Rutland X-Mailer: Apple Mail (2.2098) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1098 Lines: 32 > On Apr 14, 2015, at 10:59 AM, Mark Rutland wrote: > > On Thu, Apr 09, 2015 at 06:37:10PM +0100, Kumar Gala wrote: >> From: Abhimanyu Kapur >> >> Move the secondary_pen_release variable and the secondary_holding_pen >> entry function to asm/smp_plat.h so that the other cpu ops implementations >> can share them. > > If anything, this should all be moved into smp_spin_table.c, and made > static. > > We made a mistake with the pen (and allowing multiple CPUs to enter the > kernel at once). That mistake shouldn't be spread further. > > Mark. Yeah, it appears I can drop this and just set the secondary cores to enter secondary_entry. - k -- Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/