From: Arnd Bergmann <arnd@arndb.de>
To: Arun Ramamurthy <arun.ramamurthy@broadcom.com>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-arm-kernel@lists.infradead.org,
        Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        bcm-kernel-feedback-list@broadcom.com,
        Thomas Pugliese <thomas.pugliese@gmail.com>,
        Peter Griffin <peter.griffin@linaro.org>,
        Jonathan Richardson <jonathar@broadcom.com>,
        Anatol Pomazau <anatol@google.com>, Ray Jui <rjui@broadcom.com>,
        Alan Stern <stern@rowland.harvard.edu>,
        Dmitry Torokhov <dtor@google.com>, David Mosberger <davidm@egauge.net>,
        Gregory CLEMENT <gregory.clement@free-electrons.com>,
        Kevin Hao <haokexin@gmail.com>, Paul Bolle <pebolle@tiscali.nl>,
        Mathias Nyman <mathias.nyman@linux.intel.com>,
        Scott Branden <sbranden@broadcom.com>, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org, Felipe Balbi <balbi@ti.com>,
        Tony Prisk <linux@prisktech.co.nz>
Subject: Re: [PATCHv2 2/3] usb: ehci-platform: Use devm_of_phy_get_by_index
Date: Tue, 14 Apr 2015 23:47:35 +0200
Message-ID: <4138287.C3OjQp3FFm@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <552D56EF.2020409@broadcom.com>
References: <1428963047-23666-1-git-send-email-arun.ramamurthy@broadcom.com> <552D2255.1050704@ti.com> <552D56EF.2020409@broadcom.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1131
Lines: 26

On Tuesday 14 April 2015 11:05:35 Arun Ramamurthy wrote:
> >
> > [1] ->
> > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/kbuild/kconfig-language.txt#n111
> >
> Kishon,removing select GENERIC_PHY also breaks the builds for certain 
> architectures (i386 and x84_64). Is the consensus to leave the select 
> but make GENERIC_PHY a invisible option? Thanks

I think the best solution is

- make GENERIC_PHY a silent option
- change PHY_RCAR_GEN2 to use 'select' instead of 'depends on', so
  it will still work when all other phy drivers are disabled
- change the non-phy drivers that select GENERIC_PHY to either
  use 'depends on' or no explicit dependency in case they are
  still functional without the API. Note that
  drivers/pinctrl/pinctrl-tegra-xusb.c is a phy provider as well,
  not a consumer, despite being outside of drivers/phy.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/