Date: Wed, 15 Apr 2015 10:54:41 +0200 (CEST)
From: Jiri Kosina <jkosina@suse.cz>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
cc: Borislav Petkov <bp@alien8.de>, Al Viro <viro@ZenIV.linux.org.uk>,
        Andy Lutomirski <luto@amacapital.net>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Arnd Bergmann <arnd@arndb.de>,
        "Eric W. Biederman" <ebiederm@xmission.com>,
        One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>,
        Tom Gundersen <teg@jklm.no>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Daniel Mack <daniel@zonque.org>,
        David Herrmann <dh.herrmann@gmail.com>,
        Djalal Harouni <tixxdz@opendz.org>
Subject: Re: [GIT PULL] kdbus for 4.1-rc1
In-Reply-To: <20150415084440.GF16381@kroah.com>
Message-ID: <alpine.LNX.2.00.1504151050170.26287@pobox.suse.cz>
References: <20150413204547.GB1760@kroah.com> <CALCETrVoLO2Py5OY7wyn4MBcqB7VEs5DU4E2ThVSUc8kkwR3cg@mail.gmail.com> <20150414175019.GA2874@kroah.com> <CALCETrXvXWbzsh5AuQg4Cs+uq37yoky5z6j4HH7R9H2A9GMJbQ@mail.gmail.com> <20150414192357.GA6107@kroah.com>
 <20150414192429.GC26075@pd.tnic> <20150414193229.GB6107@kroah.com> <20150414194004.GG889@ZenIV.linux.org.uk> <20150414194804.GB7540@kroah.com> <20150414195336.GG14069@pd.tnic> <20150415084440.GF16381@kroah.com>
User-Agent: Alpine 2.00 (LNX 1167 2008-08-23)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1448
Lines: 36

On Wed, 15 Apr 2015, Greg Kroah-Hartman wrote:

> If you have a technical reason for why this code shouldn't be merged, 
> great, please let me know and we can work to address that.  Andy and Al 
> have spent time reviewing and giving us comments, and that's wonderful 
> and valuable and is why I treat their comments seriously.  If you are 
> interested in the code, please review it, otherwise I don't see what 
> this adds to the conversation at all, do you?

You've actually touched another issue I see here, and that is -- the code 
is complex like crazy.

I've spent big part of past two days trying to get my head around it, but 
I am still far away from getting at least the 1000 miles overview of how 
exactly the message passing is designed.

I understand that the primary reason for this complexity is probably the 
dbus protocol specification itself.

But the problem really is that I don't think you've received even a single 
Reviewed-by: from someone who hasn't been directly involved in developing 
the code, right?

For something that's potentially such a core mechanism as a completely 
new, massively-adopted IPC, this does send a warning singal.

Thanks,

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/