Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756083AbbDOJaH (ORCPT ); Wed, 15 Apr 2015 05:30:07 -0400 Received: from mail-wg0-f52.google.com ([74.125.82.52]:32771 "EHLO mail-wg0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756045AbbDOJ37 (ORCPT ); Wed, 15 Apr 2015 05:29:59 -0400 Message-ID: <552E2F90.30402@gmail.com> Date: Wed, 15 Apr 2015 11:29:52 +0200 From: Sebastian Hesselbarth User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 To: Jacek Anaszewski CC: Bryan Wu , Richard Purdie , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] leds: gpio: Fix device teardown on probe deferral References: <1429046610-3001-1-git-send-email-sebastian.hesselbarth@gmail.com> <552E2B53.8030002@samsung.com> In-Reply-To: <552E2B53.8030002@samsung.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1413 Lines: 43 On 04/15/2015 11:11 AM, Jacek Anaszewski wrote: > On 04/14/2015 11:23 PM, Sebastian Hesselbarth wrote: >> In gpio_leds_create(), when devm_get_gpiod_from_child() fails with >> -EPROBE_DEFER on the second gpio led to be created, the first already >> registered led is not torn down properly. This causes create_gpio_led() >> to fail for the first led on re-probe(). >> >> Fix this misbehaviour by incrementing num_leds only if all >> potentially failing calls completed successfully. >> >> Signed-off-by: Sebastian Hesselbarth >> --- >> Cc: Bryan Wu >> Cc: Richard Purdie >> Cc: linux-leds@vger.kernel.org >> Cc: linux-kernel@vger.kernel.org >> --- >> drivers/leds/leds-gpio.c | 5 +++-- >> 1 file changed, 3 insertions(+), 2 deletions(-) > > For this patch: > > Acked-by: Jacek Anaszewski Jacek, Thanks! > I have a question regarding the sequence above on line 201: > > if (!led.name) > return ERR_PTR(-EINVAL); > > Shouldn't this be also 'goto err"? Yes, every error within the loop has to goto the err label. Mind to send a patch fixing it? Sebastian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/