Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755170AbbDOJhi (ORCPT ); Wed, 15 Apr 2015 05:37:38 -0400 Received: from mail.skyhub.de ([78.46.96.112]:42390 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751276AbbDOJh3 (ORCPT ); Wed, 15 Apr 2015 05:37:29 -0400 Date: Wed, 15 Apr 2015 11:35:07 +0200 From: Borislav Petkov To: Greg Kroah-Hartman Cc: Al Viro , Andy Lutomirski , Linus Torvalds , Andrew Morton , Arnd Bergmann , "Eric W. Biederman" , One Thousand Gnomes , Tom Gundersen , Jiri Kosina , "linux-kernel@vger.kernel.org" , Daniel Mack , David Herrmann , Djalal Harouni Subject: Re: [GIT PULL] kdbus for 4.1-rc1 Message-ID: <20150415093507.GA2282@pd.tnic> References: <20150414175019.GA2874@kroah.com> <20150414192357.GA6107@kroah.com> <20150414192429.GC26075@pd.tnic> <20150414193229.GB6107@kroah.com> <20150414194004.GG889@ZenIV.linux.org.uk> <20150414194804.GB7540@kroah.com> <20150414195336.GG14069@pd.tnic> <20150415084440.GF16381@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20150415084440.GF16381@kroah.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1750 Lines: 44 On Wed, Apr 15, 2015 at 10:44:40AM +0200, Greg Kroah-Hartman wrote: > If you really don't like userspace using features the kernel provides > you, well, there's nothing I can say that will change that odd feeling, > sorry. Are you even reading what people are saying? I don't like the mandatory(!) aspect of this, which it will eventually become. There is this thing called "choice", remember? > Really? Who in that MAINTAINERS file entry do you not trust? The fact that you're still pushing for this current design *in the face* of people pointing out serious design flaws with this makes me not really trust you. > I don't understand what this means. If you have a technical reason > for why this code shouldn't be merged, great, please let me know and > we can work to address that. Andy and Al have spent time reviewing > and giving us comments, and that's wonderful and valuable and is > why I treat their comments seriously. If you are interested in the > code, please review it, Yeah, I took a brief look at the code. It is overcomplicated. If I were to review it properly, I'd ask you to split it in small patchsets. Hell, I'm pretty sure you would do the same for code you don't know if you were in my shoes. Also, considering the complexity of this patchset, it doesn't have a single Reviewed-by by an external party. If this were any other submission, it would've been kicked to the curb a long time ago. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. -- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/