Message-id: <552E34C7.2050903@samsung.com>
Date: Wed, 15 Apr 2015 11:52:07 +0200
From: Jacek Anaszewski <j.anaszewski@samsung.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130804
 Thunderbird/17.0.8
MIME-version: 1.0
To: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Cc: Bryan Wu <cooloney@gmail.com>, Richard Purdie <rpurdie@rpsys.net>,
        linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] leds: gpio: Fix device teardown on probe deferral
References: <1429046610-3001-1-git-send-email-sebastian.hesselbarth@gmail.com>
 <552E2B53.8030002@samsung.com> <552E2F90.30402@gmail.com>
In-reply-to: <552E2F90.30402@gmail.com>
Content-type: text/plain; charset=windows-1252; format=flowed
Content-transfer-encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1556
Lines: 47

On 04/15/2015 11:29 AM, Sebastian Hesselbarth wrote:
> On 04/15/2015 11:11 AM, Jacek Anaszewski wrote:
>> On 04/14/2015 11:23 PM, Sebastian Hesselbarth wrote:
>>> In gpio_leds_create(), when devm_get_gpiod_from_child() fails with
>>> -EPROBE_DEFER on the second gpio led to be created, the first already
>>> registered led is not torn down properly. This causes create_gpio_led()
>>> to fail for the first led on re-probe().
>>>
>>> Fix this misbehaviour by incrementing num_leds only if all
>>> potentially failing calls completed successfully.
>>>
>>> Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
>>> ---
>>> Cc: Bryan Wu <cooloney@gmail.com>
>>> Cc: Richard Purdie <rpurdie@rpsys.net>
>>> Cc: linux-leds@vger.kernel.org
>>> Cc: linux-kernel@vger.kernel.org
>>> ---
>>>   drivers/leds/leds-gpio.c | 5 +++--
>>>   1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> For this patch:
>>
>> Acked-by: Jacek Anaszewski <j.anaszewski@samsung.com>
>
> Jacek, Thanks!
>
>> I have a question regarding the sequence above on line 201:
>>
>> if (!led.name)
>>      return ERR_PTR(-EINVAL);
>>
>> Shouldn't this be also 'goto err"?
>
> Yes, every error within the loop has to goto the err label.
> Mind to send a patch fixing it?

OK, I'll take care of it.

-- 
Best Regards,
Jacek Anaszewski
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/