Message-ID: <552E3772.7050209@citrix.com>
Date: Wed, 15 Apr 2015 11:03:30 +0100
From: David Vrabel <david.vrabel@citrix.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.4.0
MIME-Version: 1.0
To: Bob Liu <bob.liu@oracle.com>, Stephen Rothwell <sfr@canb.auug.org.au>
CC: Jeremy Fitzhardinge <jeremy@goop.org>,
        Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
        Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
        Xen Devel <Xen-devel@lists.xensource.com>,
        <linux-next@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        Wei Liu <wei.liu2@citrix.com>, Paul Durrant <paul.durrant@citrix.com>
Subject: Re: linux-next: build failure after merge of the xen-tip tree
References: <20150413180902.59d8e9bd@canb.auug.org.au>
 <552B802A.3080709@oracle.com>
In-Reply-To: <552B802A.3080709@oracle.com>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1788
Lines: 49

On 13/04/15 09:36, Bob Liu wrote:
> Hi Stephen,
> 
> On 04/13/2015 04:09 PM, Stephen Rothwell wrote:
>> Hi all,
>>
>> After merging the xen-tip tree, today's linux-next build (x86_64
>> allmodconfig)
>> failed like this:
>>
>> drivers/char/tpm/xen-tpmfront.c: In function 'setup_ring':
>> drivers/char/tpm/xen-tpmfront.c:203:7: warning: passing argument 2 of
>> 'xenbus_grant_ring' makes pointer from integer without a cast
>>    rv = xenbus_grant_ring(dev, virt_to_mfn(priv->shr));
>>         ^
>> In file included from drivers/char/tpm/xen-tpmfront.c:17:0:
>> include/xen/xenbus.h:206:5: note: expected 'void *' but argument is of
>> type 'long unsigned int'
>>   int xenbus_grant_ring(struct xenbus_device *dev, void *vaddr,
>>       ^
>> drivers/char/tpm/xen-tpmfront.c:203:7: error: too few arguments to
>> function 'xenbus_grant_ring'
>>    rv = xenbus_grant_ring(dev, virt_to_mfn(priv->shr));
>>         ^
>> In file included from drivers/char/tpm/xen-tpmfront.c:17:0:
>> include/xen/xenbus.h:206:5: note: declared here
>>   int xenbus_grant_ring(struct xenbus_device *dev, void *vaddr,
>>       ^
>>
>> Caused by commit 1b1586eeeb8c ("xenbus_client: Extend interface to
>> support multi-page ring").
>>
>> I have used the xen-tip tree from next-20150410 for today.
>>
> 
> Sorry for this issue, I missed the xentpm-front.c file in that patch.
> (Original patch from Wei Liu already included the right modification
> which didn't exist in Paul's.)
> 
> Attached patch should fix this build failure.

Thanks. I've folded this in.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/