Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755794AbbDOKVA (ORCPT ); Wed, 15 Apr 2015 06:21:00 -0400 Received: from mout.kundenserver.de ([212.227.126.130]:64864 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753817AbbDOKUu (ORCPT ); Wed, 15 Apr 2015 06:20:50 -0400 From: Arnd Bergmann To: Thomas Gleixner Cc: David Miller , linux-kernel@vger.kernel.org, peterz@infradead.org, mingo@kernel.org, dingtianhong@huawei.com, zhangfei.gao@linaro.org, dan.carpenter@oracle.com, netdev@vger.kernel.org Subject: Re: [patch v2] net: hip04: Make tx coalesce timer actually work Date: Wed, 15 Apr 2015 12:20:01 +0200 Message-ID: <2657074.k4FFdZD9ci@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: References: <20150414.141529.797692010779414843.davem@davemloft.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:TACWPVX/tBgu4/WDMUDX6V3MposQoxu+XI9CqN0jltB/Y/CijPn +5ajuUK8e7b++IAnX3901LJ0byaDlhGANo00O+cW8wPBDhEZBXh466fA4E8siYSYKZ3WsiR SAB/aHia8skeDe6xSmRpNIr6GO0viKi9spo205d8a6pXzikQBtJOXIqqHGu2JjMPbrk3lVn Ybq7Wf+hnN9b2TSfU4ESg== X-UI-Out-Filterresults: notjunk:1; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1162 Lines: 27 On Tuesday 14 April 2015 21:42:42 Thomas Gleixner wrote: > The code sets the expiry value of the timer to a relative value and > starts it with hrtimer_start_expires. That's fine, but that only works > once. The timer is started in relative mode, so the expiry value gets > overwritten with the absolut expiry time (now + expiry). > > So once the timer expired, a new call to hrtimer_start_expires results > in an immidiately expired timer, because the expiry value is > already in the past. > > Use the proper mechanisms to (re)start the timer in the intended way. > > Signed-off-by: Thomas Gleixner > Cc: "David S. Miller" > Cc: dingtianhong > Cc: Arnd Bergmann > Cc: Zhangfei Gao > Cc: Dan Carpenter > Cc: netdev@vger.kernel.org > Acked-by: Arnd Bergmann -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/