Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754594AbbDOLIf (ORCPT ); Wed, 15 Apr 2015 07:08:35 -0400 Received: from mail-qk0-f177.google.com ([209.85.220.177]:34641 "EHLO mail-qk0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751834AbbDOLI1 (ORCPT ); Wed, 15 Apr 2015 07:08:27 -0400 Message-ID: <552E4691.5040501@hurleysoftware.com> Date: Wed, 15 Apr 2015 07:08:01 -0400 From: Peter Hurley User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Michal Simek , linux-kernel@vger.kernel.org, monstr@monstr.eu, Arnd Bergmann CC: stable@vger.kernel.org, Greg Kroah-Hartman , linux-serial@vger.kernel.org, Jiri Slaby Subject: Re: [PATCH v2] serial: of-serial: Remove device_type = "serial" registration References: In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1967 Lines: 54 On 04/14/2015 06:03 AM, Michal Simek wrote: > Do not probe all serial drivers by of_serial.c which are using > device_type = "serial"; property. Only drivers which have valid > compatible strings listed in the driver should be probed. > > When PORT_UNKNOWN is setup probe will fail anyway. > > Arnd quotation about driver historical background: > "when I wrote that driver initially, the idea was that it would > get used as a stub to hook up all other serial drivers but after > that, the common code learned to create platform devices from DT" > > This patch fix the problem with on the system with xilinx_uartps and > 16550a where of_serial failed to register for xilinx_uartps and because > of irq_dispose_mapping() removed irq_desc. Then when xilinx_uartps was asking > for irq with request_irq() EINVAL is returned. The problem is that irq_create_mapping()/irq_dispose_mapping() is not symmetrical, which breaks the device probe model. With that fixed, no change would be required here. Regards, Peter Hurley > Signed-off-by: Michal Simek > CC: > --- > > Changes in v2: > - Extend patch description > > drivers/tty/serial/of_serial.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/tty/serial/of_serial.c b/drivers/tty/serial/of_serial.c > index 33fb94f78967..0a52c8b55a5f 100644 > --- a/drivers/tty/serial/of_serial.c > +++ b/drivers/tty/serial/of_serial.c > @@ -344,7 +344,6 @@ static struct of_device_id of_platform_serial_table[] = { > { .compatible = "ibm,qpace-nwp-serial", > .data = (void *)PORT_NWPSERIAL, }, > #endif > - { .type = "serial", .data = (void *)PORT_UNKNOWN, }, > { /* end of list */ }, > }; > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/