Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932262AbbDOLJS (ORCPT ); Wed, 15 Apr 2015 07:09:18 -0400 Received: from mail-wi0-f174.google.com ([209.85.212.174]:36839 "EHLO mail-wi0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752038AbbDOLJJ (ORCPT ); Wed, 15 Apr 2015 07:09:09 -0400 Date: Wed, 15 Apr 2015 12:09:05 +0100 From: Matt Fleming To: Borislav Petkov Cc: Andy Lutomirski , Greg Kroah-Hartman , "Kweh, Hock Leong" , Ming Lei , Ong Boon Leong , LKML , "linux-efi@vger.kernel.org" , Sam Protsenko , Peter Jones , Roy Franz Subject: Re: [PATCH v4 1/2] firmware_loader: introduce new API - request_firmware_direct_full_path() Message-ID: <20150415110905.GC4804@codeblueprint.co.uk> References: <1429004697-28320-1-git-send-email-hock.leong.kweh@intel.com> <1429004697-28320-2-git-send-email-hock.leong.kweh@intel.com> <20150414140806.GD5989@kroah.com> <20150414161833.GE14069@pd.tnic> <20150415101455.GB4804@codeblueprint.co.uk> <20150415101805.GC2282@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150415101805.GC2282@pd.tnic> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1340 Lines: 33 On Wed, 15 Apr, at 12:18:05PM, Borislav Petkov wrote: > On Wed, Apr 15, 2015 at 11:14:55AM +0100, Matt Fleming wrote: > > Well, I haven't come across a scenario where you need a brand new > > interface for getting it *out* of the kernel again. > > Well, how are we going to read crash data on next boot then? EFI var or > what? Are we going to have a generic interface like > > /sys/.../capsule/... > > or how are we imagining this to look like? You can read it out in userspace using the existing pstorefs code. The last thing we need to do is introduce more userspace APIs ;-) It's possible (and desirable) to separate the input interface from output. I've written patches in the past where the EFI kernel subsystem discovers capsules with a specific GUID reserved for crash data, and then hands that data to the pstore subsystem. Things are then exposed via pstorefs. The capsule code would just be another backend to pstore, similar to how the EFI variable code works today. I am in no way advocating for yet another crash API. -- Matt Fleming, Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/