Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756197AbbDOLv2 (ORCPT ); Wed, 15 Apr 2015 07:51:28 -0400 Received: from cantor2.suse.de ([195.135.220.15]:47265 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754351AbbDOLvS (ORCPT ); Wed, 15 Apr 2015 07:51:18 -0400 Date: Wed, 15 Apr 2015 13:51:12 +0200 From: Jean Delvare To: Ivan Khoronzhuk Cc: linux-kernel@vger.kernel.org, matt.fleming@intel.com, ard.biesheuvel@linaro.org, grant.likely@linaro.org, linux-api@vger.kernel.org, linux-doc@vger.kernel.org, mikew@google.com, dmidecode-devel@nongnu.org, leif.lindholm@linaro.org, msalter@redhat.com, roy.franz@linaro.org Subject: Re: [Patch 1/3] firmware: dmi_scan: rename dmi_table to dmi_decode_table Message-ID: <20150415135112.494d14f9@endymion.delvare> In-Reply-To: <1427979423-22767-2-git-send-email-ivan.khoronzhuk@globallogic.com> References: <1427979423-22767-1-git-send-email-ivan.khoronzhuk@globallogic.com> <1427979423-22767-2-git-send-email-ivan.khoronzhuk@globallogic.com> Organization: SUSE Linux X-Mailer: Claws Mail 3.10.1 (GTK+ 2.24.23; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 824 Lines: 24 On Thu, 2 Apr 2015 15:57:01 +0300, Ivan Khoronzhuk wrote: > The "dmi_table" function looks like data instance, but it does DMI > table decode. This patch renames it to "dmi_decode_table" name as > more appropriate. That allows us to use "dmi_table" name for correct > purposes. > > Signed-off-by: Ivan Khoronzhuk > --- > drivers/firmware/dmi_scan.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > (...) Yes, as discussed before, good idea. Reviewed-by: Jean Delvare -- Jean Delvare SUSE L3 Support -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/