Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753038AbbDOMP1 (ORCPT ); Wed, 15 Apr 2015 08:15:27 -0400 Received: from mail-wi0-f169.google.com ([209.85.212.169]:32872 "EHLO mail-wi0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751909AbbDOMPT (ORCPT ); Wed, 15 Apr 2015 08:15:19 -0400 From: Grant Likely Subject: Re: [PATCH] of/fdt: fix allocation size for device node path To: Ricky Liang Cc: Ricky Liang , Rob Herring , "open list:OPEN FIRMWARE AND..." , open list In-Reply-To: <1428986165-6250-1-git-send-email-jcliang@chromium.org> References: <1428986165-6250-1-git-send-email-jcliang@chromium.org> Date: Wed, 15 Apr 2015 13:15:15 +0100 Message-Id: <20150415121515.8E1FAC40A0B@trevor.secretlab.ca> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1083 Lines: 38 On Tue, 14 Apr 2015 12:36:05 +0800 , Ricky Liang wrote: > The allocation size of device node path is off by one which drops the > '\0' terminator. > > Signed-off-by: Ricky Liang This looks like something that should be backported to stable. Do you agree? g. > --- > drivers/of/fdt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c > index 3a896c9..98a9e6e 100644 > --- a/drivers/of/fdt.c > +++ b/drivers/of/fdt.c > @@ -172,7 +172,7 @@ static void * unflatten_dt_node(void *blob, > if (!pathp) > return mem; > > - allocl = l++; > + allocl = ++l; > > /* version 0x10 has a more compact unit name here instead of the full > * path. we accumulate the full path size using "fpsize", we'll rebuild > -- > 2.1.2 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/