Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753661AbbDOMWg (ORCPT ); Wed, 15 Apr 2015 08:22:36 -0400 Received: from cantor2.suse.de ([195.135.220.15]:48802 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751567AbbDOMWa (ORCPT ); Wed, 15 Apr 2015 08:22:30 -0400 Message-ID: <552E5803.6050902@suse.cz> Date: Wed, 15 Apr 2015 14:22:27 +0200 From: Michal Marek User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Fabian Frederick , linux-kernel@vger.kernel.org CC: Andrew Morton , "J. Bruce Fields" , Julia Lawall , Gilles Muller , Nicolas Palix , cocci@systeme.lip6.fr Subject: Re: [PATCH V2 linux-next] scripts/coccinelle/misc/bugon.cocci: update bug_on conversion warning References: <1428613084-2861-1-git-send-email-fabf@skynet.be> In-Reply-To: <1428613084-2861-1-git-send-email-fabf@skynet.be> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 750 Lines: 21 On 2015-04-09 22:58, Fabian Frederick wrote: > if()/BUG conversion to BUG_ON must be avoided when there's side effect > in condition. The reason being BUG_ON won't execute the condition when CONFIG_BUG > is not defined. > > Inspired-by: J. Bruce Fields > Suggested-by: Julia Lawall > Acked-by: Julia Lawall > Signed-off-by: Fabian Frederick > --- > V2: s/condition/the condition/ Applied to kbuild.git#misc. Michal -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/