Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755309AbbDOMwm (ORCPT ); Wed, 15 Apr 2015 08:52:42 -0400 Received: from mail-wi0-f170.google.com ([209.85.212.170]:37812 "EHLO mail-wi0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753557AbbDOMwe (ORCPT ); Wed, 15 Apr 2015 08:52:34 -0400 MIME-Version: 1.0 In-Reply-To: <1428869786-26897-1-git-send-email-f.fainelli@gmail.com> References: <55259B4D.2020304@gmail.com> <1428869786-26897-1-git-send-email-f.fainelli@gmail.com> From: Rob Herring Date: Wed, 15 Apr 2015 07:52:12 -0500 Message-ID: Subject: Re: [PATCH] of/fdt: Remove "reg" data prints from early_init_dt_scan_memory To: Florian Fainelli Cc: "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Rob Herring , Grant Likely , Frank Rowand Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2028 Lines: 52 On Sun, Apr 12, 2015 at 3:16 PM, Florian Fainelli wrote: > Commit 51975db0b7333 ("of/flattree: merge early_init_dt_scan_memory() > common code") consolidated some code from PowerPC (typically > big-endian), and ended-up adding a pr_debug() printing reg properties in > big-endian (DT native) format, not CPU endian. > > This debug print suffers from two problems: > - we only print 4 "reg" values, while there could be more on typical > systems having multiple memory ranges > - we print these 4 "reg" values in FDT endianess, that is big-endian, > and these values could be confusing for little-endian configurations > > Since we are already printing the base address and size of the memory > regions parsed by early_init_dt_scan_memory() later in a way that is > both endian correct, and takes into account arbitrary number of memory > banks, just remove that part of the debug print. > > Suggested-by: Frank Rowand > Signed-off-by: Florian Fainelli > --- > Patch against devicetree/next Applied. Thanks. Rob > > drivers/of/fdt.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c > index 3a896c9..34bdc4d 100644 > --- a/drivers/of/fdt.c > +++ b/drivers/of/fdt.c > @@ -879,8 +879,7 @@ int __init early_init_dt_scan_memory(unsigned long node, const char *uname, > > endp = reg + (l / sizeof(__be32)); > > - pr_debug("memory scan node %s, reg size %d, data: %x %x %x %x,\n", > - uname, l, reg[0], reg[1], reg[2], reg[3]); > + pr_debug("memory scan node %s, reg size %d,\n", uname, l); > > while ((endp - reg) >= (dt_root_addr_cells + dt_root_size_cells)) { > u64 base, size; > -- > 2.1.0 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/