Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755466AbbDOPdE (ORCPT ); Wed, 15 Apr 2015 11:33:04 -0400 Received: from e06smtp14.uk.ibm.com ([195.75.94.110]:39079 "EHLO e06smtp14.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754695AbbDOPc6 (ORCPT ); Wed, 15 Apr 2015 11:32:58 -0400 Date: Wed, 15 Apr 2015 17:32:51 +0200 From: Cornelia Huck To: Rusty Russell Cc: "Michael S. Tsirkin" , linux-kernel@vger.kernel.org, Pawel Moll , virtio-dev@lists.oasis-open.org, virtualization@lists.linux-foundation.org Subject: Re: [PATCH v3 0/6] virtio_balloon: virtio 1 support Message-ID: <20150415173251.08daa268.cornelia.huck@de.ibm.com> In-Reply-To: <87r3rmrzhb.fsf@rustcorp.com.au> References: <1427884468-23930-1-git-send-email-mst@redhat.com> <20150412170141-mutt-send-email-mst@redhat.com> <87h9sjtsvb.fsf@rustcorp.com.au> <20150414102438.11d12347.cornelia.huck@de.ibm.com> <20150414103036-mutt-send-email-mst@redhat.com> <20150414115053.78189c71.cornelia.huck@de.ibm.com> <20150414115440-mutt-send-email-mst@redhat.com> <87r3rmrzhb.fsf@rustcorp.com.au> Organization: IBM Deutschland Research & Development GmbH Vorsitzende des Aufsichtsrats: Martina Koederitz =?UTF-8?B?R2VzY2jDpGZ0c2bDvGhydW5nOg==?= Dirk Wittkopp Sitz der Gesellschaft: =?UTF-8?B?QsO2Ymxpbmdlbg==?= Registergericht: Amtsgericht Stuttgart, HRB 243294 X-Mailer: Claws Mail 3.8.0 (GTK+ 2.24.10; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15041515-0017-0000-0000-000003BA56D1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1175 Lines: 37 On Wed, 15 Apr 2015 10:15:20 +0930 Rusty Russell wrote: > OK, I've merged this with one change: > > +static void stats_sg_init(struct virtio_balloon *vb, struct scatterlist *sg) > +{ > + sg_init_one(sg, vb->stats, sizeof(vb->stats)); > +} > + > ... > - sg_init_one(&sg, vb->stats, sizeof(vb->stats)); > + stats_sg_init(vb, &sg); > > This is no longer a meaningful change, so I removed it. > > Here's the final result: > > From: Michael S. Tsirkin > Subject: virtio_balloon: transitional interface > > Virtio 1.0 doesn't include a modern balloon device. > But it's not a big change to support a transitional > balloon device: this has the advantage of supporting > existing drivers, transparently. > > Signed-off-by: Michael S. Tsirkin > Acked-by: Cornelia Huck > Signed-off-by: Rusty Russell > Looks good to me. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/