Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965307AbbDOQry (ORCPT ); Wed, 15 Apr 2015 12:47:54 -0400 Received: from cdptpa-outbound-snat.email.rr.com ([107.14.166.227]:23801 "EHLO cdptpa-oedge-vip.email.rr.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S965296AbbDOQrm (ORCPT ); Wed, 15 Apr 2015 12:47:42 -0400 Date: Wed, 15 Apr 2015 12:47:28 -0400 From: Steven Rostedt To: Greg Kroah-Hartman Cc: Jiri Kosina , Borislav Petkov , Al Viro , Andy Lutomirski , Linus Torvalds , Andrew Morton , Arnd Bergmann , "Eric W. Biederman" , One Thousand Gnomes , Tom Gundersen , "linux-kernel@vger.kernel.org" , Daniel Mack , David Herrmann , Djalal Harouni Subject: Re: [GIT PULL] kdbus for 4.1-rc1 Message-ID: <20150415164728.GA24936@home.goodmis.org> References: <20150414192357.GA6107@kroah.com> <20150414192429.GC26075@pd.tnic> <20150414193229.GB6107@kroah.com> <20150414194004.GG889@ZenIV.linux.org.uk> <20150414194804.GB7540@kroah.com> <20150414195336.GG14069@pd.tnic> <20150415084440.GF16381@kroah.com> <20150415090948.GA17347@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150415090948.GA17347@kroah.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-RR-Connecting-IP: 107.14.168.118:25 X-Cloudmark-Score: 0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1938 Lines: 45 On Wed, Apr 15, 2015 at 11:09:48AM +0200, Greg Kroah-Hartman wrote: > > > But the problem really is that I don't think you've received even a single > > Reviewed-by: from someone who hasn't been directly involved in developing > > the code, right? > > I've asked for it, but finding people to review code is hard, as you Perhaps try harder. You know more kernel developers than I do. You don't have anyone you can say "hey, I need this code reviewed, can you spend some time to review it for me"? I have a few developers that are willing to do that for me, and I wont push some code (if it is complex) until they give their review-by for it. I did that with the latest TRACE_DEFINE_ENUM() code, as well as my ftrace trampoline code and the multi buffer code. None of that went in until I had their reviewed-by tags. > know. It's only 13k lines long, smaller than a serial port driver (my > unit of code review), so it's not all that big. Length of code does not determine the complexity of it. > > It's smaller than the USB3 host controller driver as well, and very few > people ever reviewed that beast :) > > > For something that's potentially such a core mechanism as a completely > > new, massively-adopted IPC, this does send a warning singal. > > If you know of a way to force others to review code, please let me know. Keep asking, that's the best way. That's what I do. Also, I really like Alan's approach to this. Let me requote it here: - stop writing a dbus only file system - figure out what a messaging "vfs" looks like - figure out what an clean low level kernel model looks like - figure out what has to be where to put the policy in userspace -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/