Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756686AbbDOR3L (ORCPT ); Wed, 15 Apr 2015 13:29:11 -0400 Received: from casper.infradead.org ([85.118.1.10]:36970 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754357AbbDOR3I (ORCPT ); Wed, 15 Apr 2015 13:29:08 -0400 Date: Wed, 15 Apr 2015 19:28:56 +0200 From: Peter Zijlstra To: Kan Liang Cc: acme@kernel.org, eranian@google.com, andi@firstfloor.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V2 1/6] perf,core: allow invalid context events to be part of sw/hw groups Message-ID: <20150415172856.GA5029@twins.programming.kicks-ass.net> References: <1429084576-1078-1-git-send-email-kan.liang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1429084576-1078-1-git-send-email-kan.liang@intel.com> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 849 Lines: 22 On Wed, Apr 15, 2015 at 03:56:11AM -0400, Kan Liang wrote: > The event count only be read when the event is already > sched_in. Yeah, so no. This breaks what groups are. Group events _must_ be co-scheduled. You cannot guarantee you can schedule events from another PMU. Also, I cannot see how this can possibly work, you cannot put these things on the same event_context. Also, how does this work wrt cpumasks, regular events are per cpu, uncore events are per node. There is so much broken stuff here without explanation its not funny. Please explain how this does not completely wreck everything? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/