Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932829AbbDOSF1 (ORCPT ); Wed, 15 Apr 2015 14:05:27 -0400 Received: from casper.infradead.org ([85.118.1.10]:37211 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932744AbbDOSFT (ORCPT ); Wed, 15 Apr 2015 14:05:19 -0400 Date: Wed, 15 Apr 2015 20:05:06 +0200 From: Peter Zijlstra To: Kan Liang Cc: linux-kernel@vger.kernel.org, mingo@kernel.org, acme@infradead.org, eranian@google.com, andi@firstfloor.org Subject: Re: [PATCH V6 3/6] perf, x86: large PEBS interrupt threshold Message-ID: <20150415180506.GB5029@twins.programming.kicks-ass.net> References: <1428597466-8154-1-git-send-email-kan.liang@intel.com> <1428597466-8154-4-git-send-email-kan.liang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1428597466-8154-4-git-send-email-kan.liang@intel.com> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 770 Lines: 20 On Thu, Apr 09, 2015 at 12:37:43PM -0400, Kan Liang wrote: > @@ -280,8 +280,9 @@ static int alloc_pebs_buffer(int cpu) > ds->pebs_absolute_maximum = ds->pebs_buffer_base + > max * x86_pmu.pebs_record_size; > > - ds->pebs_interrupt_threshold = ds->pebs_buffer_base + > - thresh * x86_pmu.pebs_record_size; > + if (x86_pmu.intel_cap.pebs_format < 1) > + ds->pebs_interrupt_threshold = ds->pebs_buffer_base + > + x86_pmu.pebs_record_size; > > return 0; > } I can't seem to figure out what this is about.. help? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/