Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756359AbbDOSgB (ORCPT ); Wed, 15 Apr 2015 14:36:01 -0400 Received: from mga11.intel.com ([192.55.52.93]:33594 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756197AbbDOSgA convert rfc822-to-8bit (ORCPT ); Wed, 15 Apr 2015 14:36:00 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,582,1422950400"; d="scan'208";a="714215074" From: "Liang, Kan" To: Peter Zijlstra CC: "linux-kernel@vger.kernel.org" , "mingo@kernel.org" , "acme@infradead.org" , "eranian@google.com" , "andi@firstfloor.org" Subject: RE: [PATCH V6 3/6] perf, x86: large PEBS interrupt threshold Thread-Topic: [PATCH V6 3/6] perf, x86: large PEBS interrupt threshold Thread-Index: AQHQcuOidiZLwwq4gkqqdFhVF86DmJ1N4YQAgACHnEA= Date: Wed, 15 Apr 2015 18:35:48 +0000 Message-ID: <37D7C6CF3E00A74B8858931C1DB2F077017C733A@SHSMSX103.ccr.corp.intel.com> References: <1428597466-8154-1-git-send-email-kan.liang@intel.com> <1428597466-8154-4-git-send-email-kan.liang@intel.com> <20150415180506.GB5029@twins.programming.kicks-ass.net> In-Reply-To: <20150415180506.GB5029@twins.programming.kicks-ass.net> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 970 Lines: 27 > > On Thu, Apr 09, 2015 at 12:37:43PM -0400, Kan Liang wrote: > > @@ -280,8 +280,9 @@ static int alloc_pebs_buffer(int cpu) > > ds->pebs_absolute_maximum = ds->pebs_buffer_base + > > max * x86_pmu.pebs_record_size; > > > > - ds->pebs_interrupt_threshold = ds->pebs_buffer_base + > > - thresh * x86_pmu.pebs_record_size; > > + if (x86_pmu.intel_cap.pebs_format < 1) > > + ds->pebs_interrupt_threshold = ds->pebs_buffer_base + > > + x86_pmu.pebs_record_size; > > > > return 0; > > } > > I can't seem to figure out what this is about.. help? We move AUTO_RELOAD and large PEBS check to intel_pmu_hw_config. But for earlier platform, it calls x86_pmu_hw_config. So we force single PEBS record for old platform. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/