Date: Wed, 15 Apr 2015 15:16:51 -0400
From: Steven Rostedt <rostedt@goodmis.org>
To: Jason Low <jason.low2@hp.com>
Cc: Ingo Molnar <mingo@kernel.org>, Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Mel Gorman <mel@csn.ul.ie>, Rik van Riel <riel@redhat.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Thomas Gleixner <tglx@linutronix.de>, linux-kernel@vger.kernel.org,
        "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Oleg Nesterov <oleg@redhat.com>,
        Mike Galbraith <umgwanakikbuti@gmail.com>,
        Frederic Weisbecker <fweisbec@gmail.com>, Mel Gorman <mgorman@suse.de>,
        Preeti U Murthy <preeti@linux.vnet.ibm.com>, hideaki.kimura@hp.com,
        Aswin Chandramouleeswaran <aswin@hp.com>,
        Scott J Norton <scott.norton@hp.com>
Subject: Re: [PATCH 1/3] sched, timer: Remove usages of ACCESS_ONCE in the
 scheduler
Message-ID: <20150415151651.312c8f48@gandalf.local.home>
In-Reply-To: <1429123749.7039.107.camel@j-VirtualBox>
References: <1429052986-9420-1-git-send-email-jason.low2@hp.com>
	<1429052986-9420-2-git-send-email-jason.low2@hp.com>
	<20150414195906.3adc89d9@gandalf.local.home>
	<1429063953.7039.88.camel@j-VirtualBox>
	<20150414224059.061ec5bf@grimm.local.home>
	<20150415074601.GC13449@gmail.com>
	<1429123749.7039.107.camel@j-VirtualBox>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 826
Lines: 20

On Wed, 15 Apr 2015 11:49:09 -0700
Jason Low <jason.low2@hp.com> wrote:

> So I'll keep the READ_ONCE nested inside WRITE_ONCE for the purpose of
> this patch since this patch is a conversion from ACCESS_ONCE, but yes,
> if the original purpose of ACCESS_ONCE was to do an atomic increment,
> then the ACCESS_ONCE doesn't help with that.

For the purpose of this patch, I think it's fine, as being more
paranoid is better than not being paranoid enough.

But this has shined light onto whether it is needed or not, and we
should figure that out in the not so far future.

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/