Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756766AbbDOUGj (ORCPT ); Wed, 15 Apr 2015 16:06:39 -0400 Received: from mail-wg0-f50.google.com ([74.125.82.50]:35756 "EHLO mail-wg0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754385AbbDOUG3 (ORCPT ); Wed, 15 Apr 2015 16:06:29 -0400 Date: Wed, 15 Apr 2015 21:06:26 +0100 From: Matt Fleming To: Roy Franz Cc: Linux Kernel Mailing List , "linux-efi@vger.kernel.org" , Matt Fleming , "H. Peter Anvin" , mingo@redhat.com, x86@kernel.org Subject: Re: [PATCH] x86_64/efi: enforce 32 bit address for command line buffer Message-ID: <20150415200626.GG4804@codeblueprint.co.uk> References: <1429058752-13478-1-git-send-email-roy.franz@linaro.org> <20150415131826.GE4804@codeblueprint.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 836 Lines: 22 On Wed, 15 Apr, at 11:56:05AM, Roy Franz wrote: > Yeah, I guess it shouldn't surprise me that there is support for 64 > bit addresses there :) > > I'l spin another patch that sets boot_params->ext_cmd_line_ptr with > the upper 32 bits of the address. > Should I conditionalize this with #ifdef CONFIG_X86_64, or just do it > unconditionally, with it being a NOP > on 32 bit? (I guess I may end up with an extra cast for the 32 bit case) Unconditionally is best, I'm loathe to introduce #ifdefs unless absolutely necessary. Thanks! -- Matt Fleming, Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/