Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756718AbbDOUkC (ORCPT ); Wed, 15 Apr 2015 16:40:02 -0400 Received: from mga02.intel.com ([134.134.136.20]:18543 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753305AbbDOUjy (ORCPT ); Wed, 15 Apr 2015 16:39:54 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,583,1422950400"; d="scan'208";a="714287479" Date: Wed, 15 Apr 2015 16:39:47 -0400 From: "ira.weiny" To: "Hefty, Sean" Cc: Hal Rosenstock , Michael Wang , Roland Dreier , Hal Rosenstock , "linux-rdma@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Tom Tucker , Steve Wise , Hoang-Nam Nguyen , Christoph Raisch , infinipath , Eli Cohen , "Latif, Faisal" , Jack Morgenstein , Or Gerlitz , Haggai Eran , Tom Talpey , Jason Gunthorpe , Doug Ledford Subject: Re: [PATCH v3 01/28] IB/Verbs: Implement new callback query_transport() Message-ID: <20150415203947.GB15877@phlsvsds.ph.intel.com> References: <552BB470.4090407@profitbricks.com> <552BB4FA.5000109@profitbricks.com> <552EAF9D.8050400@dev.mellanox.co.il> <1828884A29C6694DAF28B7E6B8A82373A8FC1C7C@ORSMSX109.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1828884A29C6694DAF28B7E6B8A82373A8FC1C7C@ORSMSX109.amr.corp.intel.com> User-Agent: Mutt/1.4.2.2i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1920 Lines: 49 On Wed, Apr 15, 2015 at 01:29:31PM -0600, Hefty, Sean wrote: > > libibverbs also exposes transport at the device level. Isn't a change to > > make transport per port rather than per device needed there as well to > > be consistent with these proposed kernel changes ? If so, would the > > additional IBoE transport be exposed ? We also need to worry about > > backward compatibility for existing applications. > > Libibverbs probably can't change without bumping the major version number. If the kernel attribute structures change, this is probably something that the user_verbs module would need to handle to avoid breaking the ABI. > Transport is not directly sent thought the kernel ABI. It is fabricated when the HCA provider driver is loaded. static struct ibv_device *try_driver(struct ibv_driver *driver, struct ibv_sysfs_dev *sysfs_dev) { ... switch (dev->node_type) { case IBV_NODE_CA: case IBV_NODE_SWITCH: case IBV_NODE_ROUTER: dev->transport_type = IBV_TRANSPORT_IB; break; case IBV_NODE_RNIC: dev->transport_type = IBV_TRANSPORT_IWARP; break; case IBV_NODE_USNIC: dev->transport_type = IBV_TRANSPORT_USNIC; break; case IBV_NODE_USNIC_UDP: dev->transport_type = IBV_TRANSPORT_USNIC_UDP; break; default: dev->transport_type = IBV_TRANSPORT_UNKNOWN; break; } ... } I'm not sure how to fix this once we get to the user space problem. But I don't think it affects this set of patches. Ira -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/