Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757062AbbDPHXR (ORCPT ); Thu, 16 Apr 2015 03:23:17 -0400 Received: from mx08-00178001.pphosted.com ([91.207.212.93]:59682 "EHLO mx08-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756927AbbDPHXN (ORCPT ); Thu, 16 Apr 2015 03:23:13 -0400 Message-ID: <552F6352.1020601@st.com> Date: Thu, 16 Apr 2015 09:22:58 +0200 From: Giuseppe CAVALLARO User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Vince Bridgers , , CC: Subject: Re: [PATCH net 0/5] stmmac: Correct flow control configuration References: <1429114662-1528-1-git-send-email-vbridger@opensource.altera.com> In-Reply-To: <1429114662-1528-1-git-send-email-vbridger@opensource.altera.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.52.138.56] X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.13.68,1.0.33,0.0.0000 definitions=2015-04-16_03:2015-04-15,2015-04-16,1970-01-01 signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2283 Lines: 53 Hi Vince On 4/15/2015 6:17 PM, Vince Bridgers wrote: > This series of patches corrects flow control configuration for the Synopsys > GMAC driver. Thx for these patches For the series Acked-by: Giuseppe Cavallaro peppe > > Flow control is configured based on a configurable receive fifo size. If > less than 4Kbytes flow control is left disabled and a warning is presented. If > a receive fifo size is not specified, flow control is left disabled to > maintain current behavior. Unicast pause detection was disabled, but is now > enabled. The pause time was modified to be maximum time per a XON/XOFF > flow control mode of operation. > > This patch was tested on an Altera Cyclone 5 and an Altera Arria 10 devkit, > and verified that flow control operates as expected when enabled. > > Please consider this series for inclusion so that flow control will > function as expected for the Synopsys GMAC controller. > > Vince Bridgers (5): > stmmac: Add properties for transmit and receive fifo sizes > stmmac: Add defines and documentation for enabling flow control > stmmac: Read tx-fifo-depth and rx-fifo-depth from the devicetree > stmmac: Enable unicast pause frame detect in GMAC Register 6 > stmmac: Configure Flow Control to work correctly based on rxfifo size > > Documentation/devicetree/bindings/net/ethernet.txt | 6 +++ > Documentation/devicetree/bindings/net/stmmac.txt | 4 ++ > drivers/net/ethernet/stmicro/stmmac/common.h | 5 ++- > drivers/net/ethernet/stmicro/stmmac/dwmac1000.h | 51 ++++++++++++++++++++++ > .../net/ethernet/stmicro/stmmac/dwmac1000_core.c | 5 ++- > .../net/ethernet/stmicro/stmmac/dwmac1000_dma.c | 26 ++++++++++- > drivers/net/ethernet/stmicro/stmmac/dwmac100_dma.c | 2 +- > drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 16 ++++--- > .../net/ethernet/stmicro/stmmac/stmmac_platform.c | 4 ++ > include/linux/stmmac.h | 2 + > 10 files changed, 111 insertions(+), 10 deletions(-) > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/