Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756930AbbDPH2N (ORCPT ); Thu, 16 Apr 2015 03:28:13 -0400 Received: from mail-wi0-f169.google.com ([209.85.212.169]:34031 "EHLO mail-wi0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753998AbbDPH2G (ORCPT ); Thu, 16 Apr 2015 03:28:06 -0400 Date: Thu, 16 Apr 2015 09:28:02 +0200 From: Ingo Molnar To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org, Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] x86: Enable fast 32-bit put_user_64 for copy_to_user Message-ID: <20150416072802.GA4998@gmail.com> References: <1429091486-11443-1-git-send-email-chris@chris-wilson.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1429091486-11443-1-git-send-email-chris@chris-wilson.co.uk> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 832 Lines: 24 * Chris Wilson wrote: > For fixed sized copies, copy_to_user() will utilize __put_user_size > fastpaths. However, it is missing the translation for 64bit copies on > x86/32. Testing on a Pinetrail Atom, the 64 bit put_user fastpath is > substantially faster than the generic copy_to_user() fallback. > > Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: "H. Peter Anvin" > Cc: x86@kernel.org > CC: linux-kernel@vger.kernel.org The patch makes sense, but your Signed-off-by line is missing. Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/