Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754294AbbDPHlD (ORCPT ); Thu, 16 Apr 2015 03:41:03 -0400 Received: from mail.fireflyinternet.com ([87.106.93.118]:58962 "EHLO fireflyinternet.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751079AbbDPHk6 (ORCPT ); Thu, 16 Apr 2015 03:40:58 -0400 X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Date: Thu, 16 Apr 2015 08:40:48 +0100 From: Chris Wilson To: Ingo Molnar Cc: intel-gfx@lists.freedesktop.org, Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] x86: Enable fast 32-bit put_user_64 for copy_to_user Message-ID: <20150416074048.GC6193@nuc-i3427.alporthouse.com> Mail-Followup-To: Chris Wilson , Ingo Molnar , intel-gfx@lists.freedesktop.org, Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, linux-kernel@vger.kernel.org References: <1429091486-11443-1-git-send-email-chris@chris-wilson.co.uk> <20150416072802.GA4998@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150416072802.GA4998@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1082 Lines: 28 On Thu, Apr 16, 2015 at 09:28:02AM +0200, Ingo Molnar wrote: > > * Chris Wilson wrote: > > > For fixed sized copies, copy_to_user() will utilize __put_user_size > > fastpaths. However, it is missing the translation for 64bit copies on > > x86/32. Testing on a Pinetrail Atom, the 64 bit put_user fastpath is > > substantially faster than the generic copy_to_user() fallback. > > > > Cc: Thomas Gleixner > > Cc: Ingo Molnar > > Cc: "H. Peter Anvin" > > Cc: x86@kernel.org > > CC: linux-kernel@vger.kernel.org > > The patch makes sense, but your Signed-off-by line is missing. Sorry, totally forgot that when rewriting the changelog. Signed-off-by: Chris Wilson -Chris -- Chris Wilson, Intel Open Source Technology Centre -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/