Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933653AbbDPIFv (ORCPT ); Thu, 16 Apr 2015 04:05:51 -0400 Received: from cantor2.suse.de ([195.135.220.15]:41584 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753193AbbDPIFP (ORCPT ); Thu, 16 Apr 2015 04:05:15 -0400 From: NeilBrown To: Kishon Vijay Abraham I Date: Thu, 16 Apr 2015 18:03:04 +1000 Subject: [PATCH 3/6] phy: twl4030-usb: remove incorrect pm_runtime_get_sync() in probe function. Cc: Tony Lindgren , GTA04 owners , linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, Pavel Machek Message-ID: <20150416080304.23307.55760.stgit@notabene.brown> In-Reply-To: <20150416075945.23307.24424.stgit@notabene.brown> References: <20150416075945.23307.24424.stgit@notabene.brown> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1236 Lines: 32 The USB phy should initialize with power-off, and will be powered on by the USB system when a cable connection is detected. Having this pm_runtime_get_sync() during probe causes the phy to *always* be powered on. Removing it returns to sensible power management. Fixes: 96be39ab34b77c6f6f5cd6ae03aac6c6449ee5c4 Signed-off-by: NeilBrown --- drivers/phy/phy-twl4030-usb.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/phy/phy-twl4030-usb.c b/drivers/phy/phy-twl4030-usb.c index 590c2b1c1a94..3a707dd14238 100644 --- a/drivers/phy/phy-twl4030-usb.c +++ b/drivers/phy/phy-twl4030-usb.c @@ -715,7 +715,6 @@ static int twl4030_usb_probe(struct platform_device *pdev) pm_runtime_use_autosuspend(&pdev->dev); pm_runtime_set_autosuspend_delay(&pdev->dev, 2000); pm_runtime_enable(&pdev->dev); - pm_runtime_get_sync(&pdev->dev); /* Our job is to use irqs and status from the power module * to keep the transceiver disabled when nothing's connected. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/