Date: Thu, 16 Apr 2015 10:43:44 +0200 (CEST)
From: Jiri Kosina <jkosina@suse.cz>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
cc: Steven Rostedt <rostedt@goodmis.org>, Borislav Petkov <bp@alien8.de>,
        Richard Weinberger <richard@nod.at>,
        Andy Lutomirski <luto@amacapital.net>,
        Al Viro <viro@zeniv.linux.org.uk>,
        "Eric W. Biederman" <ebiederm@xmission.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Arnd Bergmann <arnd@arndb.de>,
        One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>,
        Tom Gundersen <teg@jklm.no>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Daniel Mack <daniel@zonque.org>,
        David Herrmann <dh.herrmann@gmail.com>,
        Djalal Harouni <tixxdz@opendz.org>
Subject: Re: [GIT PULL] kdbus for 4.1-rc1
In-Reply-To: <20150415173357.GB26146@kroah.com>
Message-ID: <alpine.LNX.2.00.1504161035570.14032@pobox.suse.cz>
References: <20150415084812.GG16381@kroah.com> <552E28C2.8070409@nod.at> <20150415092034.GA17680@kroah.com> <20150415092149.GB2310@pd.tnic> <20150415092713.GA17898@kroah.com> <20150415094410.GB2282@pd.tnic> <20150415114036.GB19274@kroah.com>
 <20150415154153.GD6801@home.goodmis.org> <20150415164033.GB25105@kroah.com> <alpine.LNX.2.00.1504151846400.14032@pobox.suse.cz> <20150415173357.GB26146@kroah.com>
User-Agent: Alpine 2.00 (LNX 1167 2008-08-23)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1419
Lines: 37

On Wed, 15 Apr 2015, Greg Kroah-Hartman wrote:

> > I originally didn't want to comment on this, but now that you are 
> > making this argument for 3rd or 4th time, I can't really resist. What 
> > exactly are you trying to "prove" by the 13k-lines argument?
> > 
> > mm/vmscan.c is less that 4k lines. Does that sole fact mean that the whole 
> > memory reclaim is trivial to review?
> 
> I'm trying to say that it's not a ton of code.  lines of code are of
> course not a valid way to judge complexity, and I'm not trying to say
> that.  I am trying to point out that it isn't "huge" by comparing it to
> other chunks of code that we all know and love.
> 
> We merge subsystems with new userspace apis that are large than this all
> the time.  I'm trying to say this isn't something "unusual" at all.

I agree with you on that point. Merging 13k lines isn't a big deal, we do 
that all the time.

But I don't think anyone in this (or previous) thread brought up the 
number of lines of kdbus as an unltimate argument for questioning or even 
NACKing it.

So I completely fail to see why this is so relevant that you keep 
repeating it.

Thanks,

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/